docs: Refreshing GlobalHeader Storybook Example #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader-example-polish
Note crashes after clicking inside.
I also move the Combobox into it's own component. I'd like to do the same for a NotificationLiveBadge.
Removed unused imports and parameters.
| {filteredTasks.length === 0 ? ( | ||
| <StyledMenuItem as="span">No Results Found</StyledMenuItem> | ||
| ) : ( | ||
| filteredTasks.map(i => ( |
There was a problem hiding this comment.
Although mapping works, we should probably use a render function like in the auto complete example:
{model.state.items.length > 0 && (
<Combobox.Menu.List cs={styleOverrides.comboboxMenuList}>
{item => <Combobox.Menu.Item>{item}</Combobox.Menu.Item>}
</Combobox.Menu.List>
)}
There was a problem hiding this comment.
I'll need some help with using this model!
mannycarrera4
requested changes
Sep 17, 2024
| const GlobalHeaderItem = createComponent('div')({ | ||
| displayName: 'GlobalHeader.Item', | ||
| Component: ({gap = 's', ...props}: HeaderItemProps, ref) => ( | ||
| <Flex gap={gap} alignItems="center" marginX={space.xs} ref={ref} {...props} /> | ||
| <Flex gap={gap} alignItems="center" marginX={system.space.x3} ref={ref} {...props} /> |
There was a problem hiding this comment.
does passing a token here work?
mannycarrera4
approved these changes
Nov 8, 2024
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
william-global-header-example-polish
|
| Run status |
|
| Run duration | 03m 41s |
| Commit |
|
| Committer | William Stanton |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
27
|
Pending
|
24
|
Skipped
|
0
|
Passing
|
1093
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.77%
|
|
|---|---|
|
Untested elements
|
1640
|
|
Tested elements
|
454
|
Accessibility
99.17%
|
|
|---|---|
|
Failed rules
|
5 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
180
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: none
The Storybook example
GlobalHeaderhad some opportunities for improved accessibility.Tooltipto icon buttonsSearchFieldwithComboboxAriaLiveRegionto demonstrate screen reader supportedCountBadgeRelease Category
Documentation, Examples
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)