fix: Revert spaceNumber values to pixel values and deprecate it #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky test on run #6328 ↗︎
Details:
|
|||||||||||||||
mannycarrera4
commented
Sep 26, 2023
|
when looking at chromatic, in Major, the radio buttons in preview don't have the hover ring: In this PR they are fixed |
alanbsmith
reviewed
Oct 18, 2023
| ```tsx | ||
| // With `rem` based `space` tokens | ||
| { | ||
| padding: `calc(${space.xl} + 2px)`; // 42px |
| We've deprecated `Table` and `TableRow` as well as all of their exported members. Please consider using [`Table in Preview`](https://workday.github.io/canvas-kit/?path=/docs/preview-table--basic) instead. | ||
| **PR:** [#2344](https://github.com/Workday/canvas-kit/pull/2344) | ||
|
|
||
| We've deprecated `Table` and `TableRow` as well as all of their exported members. Please use [`Table`](https://workday.github.io/canvas-kit/?path=/docs/preview-table--basic) in Preview instead. |
There was a problem hiding this comment.
Should we add a comment here on how the Table in preview is a full Table?
There was a problem hiding this comment.
can you clarify? do you mean a compound component?
|
Overall looks good! I just had some small comments. |
NicholasBoll
approved these changes
Oct 19, 2023
mannycarrera4
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2338
Release Category
Tokens
Release Note
We've deprecated
spaceNumbersand encourage users to use our rem basedspacetokens.