Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color-picker): Disable submit button when custom hex is invalid #2328

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

kennethjang34
Copy link
Contributor

@kennethjang34 kennethjang34 commented Sep 1, 2023

Summary

Fixes: #887

Release Category

Components


Checklist

  • Label ready for review has been added to PR

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)

Where Should the Reviewer Start?

/modules/preview-react/color-picker/lib/ColorPicker.tsx

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Screenshots or GIFs (if applicable)

Screenshot 2023-09-01 at 4 31 48 PM

Screenshot 2023-09-01 at 4 04 29 PM

@cypress
Copy link

cypress bot commented Sep 1, 2023

2 flaky tests on run #6102 ↗︎

0 941 2 0 Flakiness 2

Details:

Merge 3d726c6 into 55c53bf...
Project: canvas-kit Commit: 55029f6c9a ℹ️
Status: Passed Duration: 08:10 💡
Started: Sep 1, 2023 11:39 PM Ended: Sep 1, 2023 11:47 PM
Flakiness  Tabs.spec.ts • 1 flaky test

View Output Video

Test Artifacts
... > when the "More" button is clicked > should show the Tab overflow menu Output Screenshots Video
Flakiness  Autocomplete.spec.ts • 1 flaky test

View Output Video

Test Artifacts
... > when a value is entered > when down arrow key is pressed > when the user presses the enter key > when the use hits the "2" key > should change the filtered results Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@NicholasBoll NicholasBoll added the ready for review Code is ready for review label Sep 6, 2023
@NicholasBoll NicholasBoll changed the title fix: Disable color picker submit button when custom hex is invalid(#887) fix(color-picker): Disable submit button when custom hex is invalid Sep 6, 2023
@NicholasBoll NicholasBoll added automerge and removed ready for review Code is ready for review labels Sep 6, 2023
@alanbsmith alanbsmith enabled auto-merge (squash) September 6, 2023 17:48
@alanbsmith alanbsmith disabled auto-merge September 6, 2023 17:49
@alanbsmith alanbsmith enabled auto-merge (squash) September 6, 2023 17:49
@alanbsmith alanbsmith merged commit 6a7095b into Workday:master Sep 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color picker submit button should be disabled until something viable is entered
4 participants