Skip to content

Commit

Permalink
chore: Merge support into master (#2883)
Browse files Browse the repository at this point in the history
  • Loading branch information
alanbsmith and NicholasBoll authored Aug 23, 2024
2 parents 8415b4a + b61820c commit c2cb407
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [v10.3.55](https://github.com/Workday/canvas-kit/releases/tag/v10.3.55) (2024-08-22)

### Components

- fix(combobox): Show selected state when multiple is enabled ([#2882](https://github.com/Workday/canvas-kit/pull/2882)) ([@NicholasBoll](https://github.com/NicholasBoll))
## [v11.1.4](https://github.com/Workday/canvas-kit/releases/tag/v11.1.4) (2024-08-21)

### Documentation
Expand Down
3 changes: 2 additions & 1 deletion modules/react/combobox/lib/ComboboxMenuItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {SystemIcon} from '@workday/canvas-kit-react/icon';
import {
useListItemAllowChildStrings,
useListItemRegister,
isSelected,
} from '@workday/canvas-kit-react/collection';
import {OverflowTooltip} from '@workday/canvas-kit-react/tooltip';

Expand Down Expand Up @@ -45,7 +46,7 @@ export const useComboboxMenuItem = composeHooks(
event.preventDefault();
};

const selected = model.state.selectedIds[0] === id;
const selected = isSelected(id, model.state);

return {
role: 'option',
Expand Down
2 changes: 1 addition & 1 deletion modules/styling/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
"@emotion/serialize": "^1.0.2",
"@emotion/styled": "^11.6.0",
"@workday/canvas-kit-react": "^11.1.4",
"@workday/canvas-system-icons-web": "^3.0.0",
"@workday/canvas-tokens-web": "^2.0.0",
"@workday/canvas-system-icons-web": "^3.0.0",
"typescript": "4.2"
}
}

0 comments on commit c2cb407

Please sign in to comment.