fix: Clean up disabled options

Workday · Sep 7, 2023 · bf220f6 · bf220f6
1 parent 6e1cbfa
commit bf220f6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/modules/react/select/stories/Select.stories.mdx b/modules/react/select/stories/Select.stories.mdx
@@ -13,7 +13,7 @@ import {LabelPosition} from './examples/LabelPosition';
 import {WithIcons} from './examples/WithIcons';
 import {Required} from './examples/Required';
 import {Scrollable} from './examples/Scrollable';
-import {Dynamic} from './examples/Dynamic';
+import {UseSelectModel} from './examples/UseSelectModel';
 import {RefForwarding} from './examples/RefForwarding';
 
 <Meta title="Components/Inputs/Select" component={Select} />
@@ -118,7 +118,7 @@ forward `ref` to its underlying `<input type="text" role="combobox">` element.
 
 <ExampleCodeBlock code={RefForwarding} />
 
-### Dynamic Items
+### UseSelectModel
 
 `<Select>` supports a
 [dynamic API](/getting-started/for-developers/resources/collection-api/#dynamic-items) where you
@@ -190,7 +190,7 @@ Selected Value: {model.state.selectedIds[0]}
 </>
 ```
 
-<ExampleCodeBlock code={Dynamic} />
+<ExampleCodeBlock code={UseSelectModel} />
 
 ### Error States
 

diff --git a/modules/react/select/stories/examples/DisabledOption.tsx b/modules/react/select/stories/examples/DisabledOption.tsx
@@ -27,8 +27,8 @@ export const DisabledOptions = () => {
   return (
     <Flex flexDirection="column">
       <Select items={options} nonInteractiveIds={disabledItems}>
-        <FormField label="Contact" inputId="contact-select">
-          <Select.Input onChange={e => handleChange(e)} id="contact-select" />
+        <FormField label="Contact" inputId="disabled-options-contact-select">
+          <Select.Input onChange={e => handleChange(e)} id="disabled-options-contact-select" />
           <Select.Popper>
             <Select.Card maxHeight="200px">
               <Select.List>

diff --git a/...react/select/stories/examples/Dynamic.tsx → ...elect/stories/examples/UseSelectModel.tsx b/...react/select/stories/examples/Dynamic.tsx → ...elect/stories/examples/UseSelectModel.tsx
@@ -5,7 +5,7 @@ import {Flex} from '@workday/canvas-kit-react/layout';
 import {useSelectModel} from '../../lib/hooks';
 
 const options = [
-  {id: 'E-mail', data: {textValue: 'foo'}},
+  {id: 'E-mail'},
   {id: 'Phone'},
   {id: 'Fax (disabled)', disabled: true},
   {id: 'Mail'},
@@ -18,7 +18,7 @@ const options = [
 
 const disabledItems = options.filter(item => item.disabled === true).map(item => item.id);
 
-export const Dynamic = () => {
+export const UseSelectModel = () => {
   const model = useSelectModel({
     items: options,
     nonInteractiveIds: disabledItems,