Skip to content

Commit

Permalink
chore: Merge support into master (#3008)
Browse files Browse the repository at this point in the history
Co-authored-by: @mannycarrera4 <[email protected]>
Co-authored-by: manuel.carrera <[email protected]>
Co-authored-by: @NicholasBoll <[email protected]>
  • Loading branch information
4 people authored Oct 29, 2024
2 parents d5be4cb + e99cd4f commit bc611c1
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [v11.1.19](https://github.com/Workday/canvas-kit/releases/tag/v11.1.19) (2024-10-28)

### Components

- fix: Update Select to open with spacebar ([#3006](https://github.com/Workday/canvas-kit/pull/3006)) ([@mannycarrera4](https://github.com/mannycarrera4), manuel.carrera, [@NicholasBoll](https://github.com/NicholasBoll))
## [v12.0.6](https://github.com/Workday/canvas-kit/releases/tag/v12.0.6) (2024-10-24)

### Components
Expand Down
10 changes: 10 additions & 0 deletions cypress/component/Select.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,16 @@ describe('Select', () => {
);
});
});
context('when spacebar is typed and no value exists', () => {
beforeEach(() => {
cy.findByRole('combobox').focus();
cy.focused().realType(' ');
});
it('should open the menu', () => {
// should open the menu
cy.findByRole('listbox').should('exist');
});
});
});

context('given the "Disabled Options" story with a disabled option', () => {
Expand Down

0 comments on commit bc611c1

Please sign in to comment.