Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
mannycarrera4 authored Sep 15, 2023
1 parent 4299984 commit 5d9ddfa
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
7 changes: 3 additions & 4 deletions modules/docs/mdx/10.0-UPGRADE_GUIDE.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,9 @@ Preview and the `Menu` in Main.

### Input Icon Container

We've deprecated `InputIconContainer` from `TextInput` component, because it doesn't handle
bidirectionality or icons at the start of an input. `InputGroup` should be used instead of
deprecated `InputIconContainer`. Example of using `InputGroup` you can find in
[this story](https://workday.github.io/canvas-kit/?path=/story/components-inputs-text-input--icons).
We've deprecated `InputIconContainer` from `TextInput` component because it doesn't handle
bidirectionality or icons at the start of an input. Use `InputGroup` instead.
Here's an [example](https://workday.github.io/canvas-kit/?path=/story/components-inputs-text-input--icons) of using `InputGroup`.

## Token Updates

Expand Down
5 changes: 3 additions & 2 deletions modules/react/text-input/lib/InputIconContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {SystemIcon} from '@workday/canvas-kit-react/icon';
/**
* We've deprecated `InputIconContainer` from `TextInput` component
* together with `InputIconContainerProps`.
Please consider using [`InputGroup`](https://workday.github.io/canvas-kit/?path=/docs/components-inputs-text-input--icons).
* @deprecated
*/
export interface InputIconContainerProps extends GrowthBehavior {
Expand All @@ -26,8 +27,8 @@ const IconContainer = styled('div')({

/**
* We've deprecated `InputIconContainer` from `TextInput` component, because it doesn't handle
* bidirectionality or icons at the start of an input. `InputGroup` should be used instead of
* deprecated `InputIconContainer`.
* bidirectionality or icons at the start of an input.
Please consider using [`InputGroup`](https://workday.github.io/canvas-kit/?path=/docs/components-inputs-text-input--icons).
* @deprecated
*/

Expand Down

0 comments on commit 5d9ddfa

Please sign in to comment.