Skip to content

Commit

Permalink
chore: Merge support into master (#3002)
Browse files Browse the repository at this point in the history
Co-authored-by: @mannycarrera4 <[email protected]>
Co-authored-by: manuel.carrera <[email protected]>
  • Loading branch information
3 people authored Oct 24, 2024
2 parents cc29f64 + b23a066 commit 5681161
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [v11.1.18](https://github.com/Workday/canvas-kit/releases/tag/v11.1.18) (2024-10-23)

### Components

- fix: Ensure button label icon uses rem ([#3001](https://github.com/Workday/canvas-kit/pull/3001)) ([@mannycarrera4](https://github.com/mannycarrera4), manuel.carrera)
## [v12.0.5](https://github.com/Workday/canvas-kit/releases/tag/v12.0.5) (2024-10-23)

### Documentation
Expand Down
5 changes: 3 additions & 2 deletions modules/react/button/lib/parts/ButtonLabelIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from 'react';
import {ButtonSizes} from '../types';
import {createComponent} from '@workday/canvas-kit-react/common';
import {SystemIcon, SystemIconProps} from '@workday/canvas-kit-react/icon';
import {px2rem} from '@workday/canvas-kit-styling';

export interface ButtonLabelIconProps extends Partial<SystemIconProps> {
/**
Expand Down Expand Up @@ -42,8 +43,8 @@ export const ButtonLabelIcon = createComponent('span')({
size={iconSize}
icon={icon}
shouldMirror={shouldMirrorIcon}
width={size ? iconSizes[size] : iconSizes.large}
height={size ? iconSizes[size] : iconSizes.large}
width={px2rem(iconSize)}
height={px2rem(iconSize)}
display="inline-block"
{...elemProps}
/>
Expand Down

0 comments on commit 5681161

Please sign in to comment.