Skip to content

Commit 5681161

Browse files
alanbsmithmannycarrera4manuel.carrera
authored
chore: Merge support into master (#3002)
Co-authored-by: @mannycarrera4 <[email protected]> Co-authored-by: manuel.carrera <[email protected]>
2 parents cc29f64 + b23a066 commit 5681161

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6+
## [v11.1.18](https://github.com/Workday/canvas-kit/releases/tag/v11.1.18) (2024-10-23)
7+
8+
### Components
9+
10+
- fix: Ensure button label icon uses rem ([#3001](https://github.com/Workday/canvas-kit/pull/3001)) ([@mannycarrera4](https://github.com/mannycarrera4), manuel.carrera)
611
## [v12.0.5](https://github.com/Workday/canvas-kit/releases/tag/v12.0.5) (2024-10-23)
712

813
### Documentation

modules/react/button/lib/parts/ButtonLabelIcon.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import React from 'react';
22
import {ButtonSizes} from '../types';
33
import {createComponent} from '@workday/canvas-kit-react/common';
44
import {SystemIcon, SystemIconProps} from '@workday/canvas-kit-react/icon';
5+
import {px2rem} from '@workday/canvas-kit-styling';
56

67
export interface ButtonLabelIconProps extends Partial<SystemIconProps> {
78
/**
@@ -42,8 +43,8 @@ export const ButtonLabelIcon = createComponent('span')({
4243
size={iconSize}
4344
icon={icon}
4445
shouldMirror={shouldMirrorIcon}
45-
width={size ? iconSizes[size] : iconSizes.large}
46-
height={size ? iconSizes[size] : iconSizes.large}
46+
width={px2rem(iconSize)}
47+
height={px2rem(iconSize)}
4748
display="inline-block"
4849
{...elemProps}
4950
/>

0 commit comments

Comments
 (0)