fix: Ensure button label icon uses rem (#3001)

Fixes: #3000 [category:Components] Co-authored-by: manuel.carrera <[email protected]>
Workday · Oct 23, 2024 · 486e5fb · 486e5fb
1 parent d44c9cc
commit 486e5fb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/modules/react/button/lib/parts/ButtonLabelIcon.tsx b/modules/react/button/lib/parts/ButtonLabelIcon.tsx
@@ -2,6 +2,7 @@ import React from 'react';
 import {ButtonSizes} from '../types';
 import {createComponent} from '@workday/canvas-kit-react/common';
 import {SystemIcon, SystemIconProps} from '@workday/canvas-kit-react/icon';
+import {px2rem} from '@workday/canvas-kit-styling';
 
 export interface ButtonLabelIconProps extends Partial<SystemIconProps> {
   /**
@@ -42,8 +43,8 @@ export const ButtonLabelIcon = createComponent('span')({
         size={iconSize}
         icon={icon}
         shouldMirror={shouldMirrorIcon}
-        width={size ? iconSizes[size] : iconSizes.large}
-        height={size ? iconSizes[size] : iconSizes.large}
+        width={px2rem(iconSize)}
+        height={px2rem(iconSize)}
         display="inline-block"
         {...elemProps}
       />

diff --git a/modules/react/button/stories/button/examples/Primary.tsx b/modules/react/button/stories/button/examples/Primary.tsx
@@ -24,6 +24,6 @@ export const Primary = () => (
     <PrimaryButton icon={caretDownIcon} iconPosition="end">
       Primary
     </PrimaryButton>
-    <PrimaryButton size="small" icon={relatedActionsVerticalIcon} />
+    <PrimaryButton icon={relatedActionsVerticalIcon} />
   </Flex>
 );