fix: Clean up useselectinput

Workday · Sep 6, 2023 · 1b24e52 · 1b24e52
1 parent 9311d96
commit 1b24e52
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/modules/react/select/lib/Select.tsx b/modules/react/select/lib/Select.tsx
@@ -27,16 +27,15 @@ export const SelectInput = createSubcomponent(TextInput)({
   modelHook: useSelectModel,
   elemPropsHook: useSelectInput,
 })<SelectInputProps>(
-  ({placeholder = 'Choose an Option', width, inputStartIcon, ...props}, Element, model) => {
+  ({placeholder = 'Choose an Option', inputStartIcon, ...props}, Element, model) => {
     return (
-      <InputGroup width={width}>
+      <InputGroup>
         {inputStartIcon && model.state.selectedIds.length > 0 && (
           <InputGroup.InnerStart pointerEvents="none">
             <SystemIcon icon={inputStartIcon} />
           </InputGroup.InnerStart>
         )}
         <InputGroup.Input
-          width={width}
           as={Element}
           placeholder={placeholder}
           style={{caretColor: 'transparent', cursor: 'default'}}

diff --git a/modules/react/select/lib/hooks/useSelectInput.ts b/modules/react/select/lib/hooks/useSelectInput.ts
@@ -123,8 +123,6 @@ export const useSelectInput = composeHooks(
           keysToOpenSelect.includes(event.key) ||
           (event.key === ' ' && model.state.visibility === 'hidden' && keySofar.current === '')
         ) {
-          // set the width of the popup when the select is triggered to open by a specified key
-          model.events.setWidth(event.currentTarget.clientWidth);
           //show the menu when enter is typed
           model.events.show();
         }
@@ -140,7 +138,7 @@ export const useSelectInput = composeHooks(
           if (model.state.visibility === 'hidden') {
             model.events.goTo({id: model.state.items[foundIndex].id});
 
-            if (model.state.isVirtualized && model.state.selectedIds.length > 0) {
+            if (model.state.selectedIds.length > 0) {
               model.state.UNSTABLE_virtual.scrollToIndex(foundIndex);
             }
           }
@@ -190,9 +188,6 @@ export const useSelectInput = composeHooks(
       },
 
       onClick(event: React.MouseEvent) {
-        if (model.state.visibility === 'hidden') {
-          model.events.setWidth(event.currentTarget.clientWidth);
-        }
         // When you click the menu and there's a selected item
         // scroll to that selected item
         if (model.state.selectedIds.length > 0) {