Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move handbook meta info inside complementary landmark #504

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Feb 19, 2024

Closes #400.

This PR moves the handbook meta above the chapter list in the HTML hierarchy and then uses flex order to visually place it below the chapter list, and also adding a dividing line between them.

Below is a screencast that shows when entering the complementary landmark, the screen reader first reads the handbook content and then the chapter list, which I suppose meets the request. Regarding the desktop view and @jasmussen's question about how it would look in mobile view when the three columns just became rows, could @WordPress/meta-design take a look and give some feedback?

Screen.Capture.on.2024-02-20.at.05-29-54.mov

@renintw renintw requested review from adamwoodnz and ryelle February 19, 2024 20:44
@renintw renintw self-assigned this Feb 19, 2024
@renintw renintw added layout Accessibility Issues related to keyboard navigation, screen readers, etc Redesign labels Feb 19, 2024
@renintw renintw added this to the Iteration 1 milestone Feb 19, 2024
@ryelle
Copy link
Contributor

ryelle commented Feb 19, 2024

This introduces a difference between source order and visual order, so when tabbing through, the focus moves to the meta before the chapter list. This works for sighted mouse users & non-sighted keyboard users, but could be confusing for anyone sighted using keyboard nav or a screen reader. Especially when the meta is pushed down the screen by the Chapter list, the focus jumps around a lot.

keyboard-nav.mp4

This is worse on small screens, since the chapter list is already pulled out of order, it jumps up and down.

keyboard-nav-small.mp4

Maybe it could be moved to after the Chapters list in the source as well?

@jasmussen
Copy link
Collaborator

The source order & visual order is the challenge at hand here, because visually it looks nice. The main challenge here is that hierarchically, ideally we have chapters > toc > content. Across desktop that's a row of 3 columns, on mobile it's a stack of 2 collapsed elements (chapters and docs in thar order), and then content.

Can the meta info live inside the chapters element? Would that thread the needle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc layout Redesign
Projects
Status: 👀 In review (PRs only)
Development

Successfully merging this pull request may close these issues.

Move handbook meta info inside complementary landmark
3 participants