-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move handbook meta info inside complementary landmark #400
Comments
@adamwoodnz, would you mind sharing more context here? What does the 'meta information' mentioned here refer to? |
Sure, the request is to move the handbook article meta info from the bottom of the article into the complementary landmark, ie. the container for the Chapter List. If we make this change in the markup, visually it would mean moving from to If this isn't a desirable visual change we could duplicate the content and use the @WordPress/meta-design what do you think about the request please? |
I think we can probably move it in there. How would it look if the three columns just became rows? If need be we can refine the prose a bit. |
I noticed Alex initially suggested placing the meta info above the Chapters heading. I'm curious about the potential impact if we place it on the bottom of the Chapter List as it's more visually coherent. cc @alexstine
Does it make sense to put it on top of the collapsed chapter list dropdown? |
I agree it would look better below the chapters when positioned to the side. We could place it above in the markup though and use flex order to place it below visually. |
@adamwoodnz Doing this would cause an WCAG failure. You are unable to move this information visually because of the tabbable link.
https://developer.wordpress.org/block-editor/contributors/ Essentially, the focus indicator would be lost when the link is focussed wrapped in the Thanks. |
Would it be possible to also move the meta information inside the complementary landmark? It would likely be more discoverable just above the Chapters heading.
Originally posted by @alexstine in #368 (comment)
The text was updated successfully, but these errors were encountered: