Fix #60: remove "Move to plugins" from the per-item More-options menu#71
Open
lucasmendes-design wants to merge 1 commit into
Open
Fix #60: remove "Move to plugins" from the per-item More-options menu#71lucasmendes-design wants to merge 1 commit into
lucasmendes-design wants to merge 1 commit into
Conversation
May 2026 usability testing surfaced that testers couldn't differentiate "Move to plugins" from "Reset to default" — both actions returned a top-level item back into its baseline group, so they read as duplicates and produced unpredictable results when the item was inside the group already. Remove the dynamic "Move to <group>" loop from move-menu.js's choices. Keep "Move to top level" (the inverse direction is a distinct, unambiguous action). Cross-group moves remain available via drag — and DES-647 tracks broadening drag to all sidebar items anyway. Also drops the now-unused `groupIds` local. Left the `in_group` branch in `crossMove` in place: it's unreachable now, but removing it would inflate the diff and the function still handles `top_level` cleanly. Worth a tiny follow-up cleanup if a reviewer wants it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60. Linear: DES-656. Off
trunkdirectly — no stack dependencies. Independent of #70 (which fixed a related pointerdown-dismiss bug in the same menu).Summary
May 2026 usability testing surfaced that two entries in the per-row More-options menu read as duplicates:
Testers reported clicking one expecting the behaviour of the other, and couldn't articulate the difference. The closest framing from the synthesis ticket:
This PR removes "Move to plugins" entirely and keeps Reset to default as the canonical "send this back where it came from" action. Move to top level (the inverse direction) is unambiguous — it stays.
What changed
src/customizer/move-menu.jsonly:for ( const gid of groupIds )loop that generated the "Move to " choices. With only one group today (plugins), that was always exactly one entry: "Move to plugins".groupIdslocal.The menu's final choice set:
What was NOT changed
crossMove'sin_groupbranch is left in place. It's unreachable today but the function still handlestop_levelcleanly, and inflating the diff to remove a few unused lines wasn't worth it. Tiny follow-up cleanup if a reviewer wants it.Manual verification
Local Studio site (PHP 8.4 / WP 6.9.4, SQLite) in customize mode, blueprint plugin set.
Tests
JS-only behaviour change. The existing tests don't pin the exact set of choices in the menu (
grouping.test.jsandexpand-collapse.test.jscover different code paths). No test updates needed; CI gates the rest of the suite.🤖 Generated with Claude Code