Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid login issue in deployment E2E tests #2065

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

brandonpayton
Copy link
Member

@brandonpayton brandonpayton commented Dec 10, 2024

Motivation for the change, related issues

The deployment E2E tests are currently broken. WP admin email verification for an old WP 6.5 build appears to be causing a login failure error during the deployment tests.

An example of a failing screenshot comparison due to failed login is here.

Implementation details

This PR maxes out the admin_email_lifespan value (for 32-bit PHP) so there should be no further admin email verification redirect.

Testing Instructions (or ideally a Blueprint)

  • CI

WP admin email verification for an old WP 6.5 build
appears to be causing a login failure error during the
deployment tests. We aren't testing login, so lets just
disable login for these tests.
@brandonpayton brandonpayton added [Type] Bug An existing feature does not function as intended [Package][@wp-playground] Website labels Dec 10, 2024
@brandonpayton brandonpayton requested a review from a team December 10, 2024 06:11
@brandonpayton brandonpayton self-assigned this Dec 10, 2024
This is necessary to continue using the same logged-in
screenshots for reference in the tests.
@brandonpayton
Copy link
Member Author

I'm not yet sure why CI continues to fail with these E2E tests. These changes seem to fix the testing issue when run locally with

npx nx e2e:playwright playground-website -- --ui

@adamziel
Copy link
Collaborator

Hm, nothing obvious stands out to me 🤔

@brandonpayton
Copy link
Member Author

Hm, nothing obvious stands out to me 🤔

Thanks for considering this, @adamziel.

Something strange is going on with the old version, but I don't think we need to understand why. Instead, I plan to just disable logins and update the old-version reference screenshots to match that.

How did you originally generate the screenshots to match what CI will create? My plan is to just use a temp commit to generate the screenshots as part of the tests and then save those, but maybe there is a faster or easier way.

Since I ran out of time this evening, I created #2071 to temporarily disable the tests before we can fix them properly.

@adamziel
Copy link
Collaborator

@brandonpayton I think I downloaded the CI artifacts and replaced the local screenshots – the CI runner had a different set of fonts than my mac so I couldn't easily use the ones generated locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package][@wp-playground] Website [Type] Bug An existing feature does not function as intended
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants