[Data Liberation] wp-admin importer page #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
|
I'll go ahead and merge so we can start expanding that UI |
85 tasks
| @@ -866,6 +866,9 @@ private function after_entity() { | |||
| } | |||
|
|
|||
| public function current(): object { | |||
| if ( null === $this->entity_data && ! $this->is_finished() && ! $this->get_last_error() ) { | |||
| $this->next(); | |||
There was a problem hiding this comment.
@adamziel What is the purpose of calling next() within current()?
From the outside, I would expect current() to have no side-effects. It seems like it could also lead to consumers unintentionally skipping a first entity if current() happens to be called before the consumers' first explicit next() call.
There was a problem hiding this comment.
That's for lazy initializing the iterator. Foreach() calls next() after every iteration but not before. We can either eagerly initialize the iterator in the constructor or in the first current() call. An inline comment to document that could be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
A rough mockup of a wp-admin page for data liberation imports:
It actually allows you to import a WXR file, but almost nothing else works. This PR is only meant to provide a starting point to expand.
Testing Instructions (or ideally a Blueprint)
cd packages/playground/data-liberation/tests/import bash run.shcc @brandonpayton @zaerl