-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Analytics] Track install and error events #1984
base: trunk
Are you sure you want to change the base?
Changes from 2 commits
acea593
4592b34
1fa774d
ad63c49
a10dfc9
beeb585
4bc154e
718155a
b6084d1
165153d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,8 +10,12 @@ import { | |
removeClientInfo, | ||
updateClientInfo, | ||
} from './slice-clients'; | ||
import { logTrackingEvent } from '../../tracking'; | ||
import { Blueprint, StepDefinition } from '@wp-playground/blueprints'; | ||
import { | ||
logBlueprintStepEvent, | ||
logErrorEvent, | ||
logTrackingEvent, | ||
} from '../../tracking'; | ||
import { Blueprint } from '@wp-playground/blueprints'; | ||
import { logger } from '@php-wasm/logger'; | ||
import { setupPostMessageRelay } from '@php-wasm/web'; | ||
import { startPlaygroundWeb } from '@wp-playground/client'; | ||
|
@@ -100,17 +104,6 @@ export function bootSiteClient( | |
blueprint = site.metadata.runtimeConfiguration; | ||
} else { | ||
blueprint = site.metadata.originalBlueprint; | ||
// Log the names of provided Blueprint's steps. | ||
// Only the names (e.g. "runPhp" or "login") are logged. Step options like | ||
// code, password, URLs are never sent anywhere. | ||
const steps = (blueprint?.steps || []) | ||
?.filter( | ||
(step: any) => !!(typeof step === 'object' && step?.step) | ||
) | ||
.map((step) => (step as StepDefinition).step); | ||
for (const step of steps) { | ||
logTrackingEvent('step', { step }); | ||
} | ||
} | ||
|
||
let playground: PlaygroundClient; | ||
|
@@ -125,6 +118,9 @@ export function bootSiteClient( | |
onClientConnected: (playground) => { | ||
(window as any)['playground'] = playground; | ||
}, | ||
onBlueprintStepCompleted: (result, step) => { | ||
logBlueprintStepEvent(step); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, why only log the completed steps instead of all the steps? |
||
}, | ||
mounts: mountDescriptor | ||
? [ | ||
{ | ||
|
@@ -177,6 +173,7 @@ export function bootSiteClient( | |
} | ||
} catch (e) { | ||
logger.error(e); | ||
logErrorEvent('boot'); | ||
bgrgicak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
dispatch(setActiveSiteError('site-boot-failed')); | ||
dispatch(setActiveModal(modalSlugs.ERROR_REPORT)); | ||
return; | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,23 +1,69 @@ | ||||||
import { StepDefinition } from '@wp-playground/blueprints'; | ||||||
import { logger } from '@php-wasm/logger'; | ||||||
|
||||||
/** | ||||||
* Declare the global window.gtag function | ||||||
*/ | ||||||
declare global { | ||||||
interface Window { gtag: any; } | ||||||
interface Window { | ||||||
gtag: any; | ||||||
} | ||||||
} | ||||||
|
||||||
/** | ||||||
* Google Analytics event names | ||||||
*/ | ||||||
type GAEvent = 'load' | 'step'; | ||||||
type GAEvent = 'load' | 'step' | 'install' | 'error'; | ||||||
|
||||||
/** | ||||||
* Log a tracking event to Google Analytics | ||||||
* @param GAEvent The event name | ||||||
* @param Object Event data | ||||||
*/ | ||||||
export const logTrackingEvent = (event: GAEvent, data?: {[key: string]: string}) => { | ||||||
if (typeof window === 'undefined' || !window.gtag) { | ||||||
return; | ||||||
} | ||||||
window.gtag('event', event, data); | ||||||
} | ||||||
export const logTrackingEvent = ( | ||||||
event: GAEvent, | ||||||
data?: { [key: string]: string } | ||||||
) => { | ||||||
try { | ||||||
if (typeof window === 'undefined' || !window.gtag) { | ||||||
return; | ||||||
} | ||||||
window.gtag('event', event, data); | ||||||
} catch (error) { | ||||||
logger.warn('Failed to log tracking event', event, data, error); | ||||||
} | ||||||
}; | ||||||
|
||||||
/** | ||||||
* Log Blueprint step events | ||||||
* @param step The Blueprint step | ||||||
*/ | ||||||
export const logBlueprintStepEvent = (step: StepDefinition) => { | ||||||
/** | ||||||
* Log the names of provided Blueprint's steps. | ||||||
* Only the names (e.g. "runPhp" or "login") are logged. Step options like | ||||||
* code, password, URLs are never sent anywhere. | ||||||
*/ | ||||||
logTrackingEvent('step', { step: step.step }); | ||||||
|
||||||
if (step.step === 'installPlugin' && (step as any).pluginData.slug) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this account for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Both. It will run whenever a step is completed. |
||||||
logTrackingEvent('install', { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the advantage of having a single There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. None, it will probably be easier to build reports with separate events. |
||||||
plugin: (step as any).pluginData.slug, | ||||||
}); | ||||||
} else if (step.step === 'installTheme' && (step as any).themeData.slug) { | ||||||
logTrackingEvent('install', { | ||||||
theme: (step as any).themeData.slug, | ||||||
}); | ||||||
} | ||||||
}; | ||||||
|
||||||
/** | ||||||
* Log error events | ||||||
* | ||||||
* @param error The error | ||||||
*/ | ||||||
export const logErrorEvent = (source: string) => { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The error source is being logged as a string, which can lead to inconsistencies. Consider using an enum or predefined constants for the error sources to ensure consistency.
Suggested change
Copilot is powered by AI, so mistakes are possible. Review output carefully before use. |
||||||
logTrackingEvent('error', { | ||||||
source, | ||||||
}); | ||||||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-rhetorical question:
It looks like this will log a generic error if
error.detail
is not defined. Do we want that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a custom event we create, so
detail.source
should always be available, but let's be safe.I added a check for the
source
in ad63c49