[Blueprints] Make landingPage handling runtime-specific and move it to PlaygroundViewport #1916
+42
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o PlaygroundViewport Goals: * Enable using ?url=/wp-admin/ on sites stored in OPFS * Don't rely on `goTo` at the Blueprints library level as that method is browser-specific. It sets iframe.src. It is not available in, say, Playground CLI or Studio. Those would have to implement their own ways of handling the landing page. ## Remaining work * Add E2E tests ## Testing instructions For temporary sites: * Go to http://localhost:5400/website-server/?url=/wp-admin/ * Confirm you're redirected to WP admin adn the `url` parameter is still present in the address bar For stored sites: * Create a local Playground site * Store it in OPFS * Add `?url=/wp-admin/` and visit it * Confirm you're redirected to WP Admin and the `url` parameter is removed from the address bar
bgrgicak
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
playground.goTo(blueprint.landingPage)call from thecompile()method to thePlaygroundViewportcomponent to:?url=/wp-admin/on OPFS sites, not just on the temporary sitesgoTomethod in all Blueprints. It setsiframe.srcwhich is browser-specific..goTo()is not available in, say, Playground CLI or Studio. Those runtimes would need their own handlers to support the landing page.Remaining work
compile()Testing instructions
For temporary sites:
urlparameter is still present in the address barFor stored sites:
?url=/wp-admin/and visit iturlparameter is removed from the address barcc @akirk @brandonpayton @bgrgicak