Polyfill DNS constants #1805
Draft
Polyfill DNS constants #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I won't have time to work on this in the next couple of days, but I'm happy to answer questions and review in the meantime. |
adamziel
force-pushed
the
trunk
branch
2 times, most recently
from
680cd19 to
2e376d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
As noted in #1516 the PHP constants related to the DNS functions polyfilled in #1067 were not defined in PHP.
This PR is a draft, as it's not proper PHP C code, I'm not 100% sure on what I need to do to make PHP compile with it successfully.Please feel free to edit as you see fit, otherwise I'll come back to this tomorrow.
cc @bgrgicak
Implementation details
Testing Instructions (or ideally a Blueprint)