Ticket/17904 #8907
Closed
Ticket/17904 #8907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e context and add a new parameter to return a WP_Error instead of a boolean. * Add min and max length restriction * Allow usernames with characters a-z 0-9 _ . - @ * Reject illegal names (multisite only) * Reject illegal logins * Username must contain at least one letter (multisite only)
New function to perform the wp_signups query in multisite. The query previously happened in `wpmu_validate_user_signup()`. On single site there is only a filter.
New function that acts as a wrapper calling `validate_username()`, `username_exists()` and `is_username_reserved()`. This function can be use to validate login for new users on single and multisite.
… in `validate_username()`
Replace `current_time()` with `time()` as per WordPress Coding Standards.
Co-authored-by: David B <[email protected]>
Co-authored-by: David B <[email protected]>
…s-controller.php Co-authored-by: David B <[email protected]>
Co-authored-by: David B <[email protected]>
…with a hyphen. Co-authored-by: Peter Wilson <[email protected]>
…with a hyphen. Co-authored-by: Peter Wilson <[email protected]>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.