Fix/translatable strings in theme json

[d-alleyne]

Trac ticket: https://core.trac.wordpress.org/ticket/62728

This is a backport of WordPress/gutenberg#66675 and WordPress/gutenberg#68243

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dalleyne.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Hi @d-alleyne! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

• PHP Coding Standards
• CSS Coding Standards
• HTML Coding Standards
• JavaScript Coding Standards
• Accessibility Coding Standards
• Inline Documentation Standards

Thank you,
The WordPress Project

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[audrasjb]

This looks good to go, thanks.

[oandregal]

This is making aspectRatios and shadow presets translatable at the block level (under settings/blocks/*), which doesn't fix the issue. Note that the Gutenberg PR WordPress/gutenberg#66675 adds shadow presets at the top level (under settings). Can we update this?

[oandregal]

Additionally, there's the question of whether these presets are valid at the block level. If so, they should also be translatable there. These are the differences I see:

Preset	Top	Block
color.palette	✅	✅
color.gradients	✅	✅
color.duotone	✅	❓
dimensions.aspectRatios	✅	❓
shadow.presets	✅	❓
spacing.spacingSizes	✅	✅
typography.fontSizes	✅	✅
typography.fontFamilies	✅	✅

[oandregal]

I tested every combination and this is what we need to do:

• Duotone: add it to the block level.
• Dimensions.aspectRatios: add it to the block level.
• Shadow: no need to add it to the block level. It can't be defined there. If it is, the shadow UI component won't be rendered.

I've already prepared the PR in Gutenberg WordPress/gutenberg#68243 for these changes.

[oandregal]

For reference, the way I tested was by adding each of those presets in Gutenberg's theme.json file under a block (e.g.: settings.blocks.{paragraph/image/etc.}) and verify that those presets were used at that particular block. If that's true, we need the presets to be translatable; otherwise, we don't.

[oandregal]

This is more general thought for reference, not need to do anything in this PR. After testing how presets work at the top vs block level, I realized they work differently. In general, the approach was that a preset defined at the block level would override the top-level ones. This is no longer true for some of them. I don't know if it's intentional or an oversight. These are the ones I've tested that work differently:

• shadow: when presets are defined at the block level, the shadow UI doesn't show up
• font families: when presets are defined at the block level, both the top and the block level presets are displayed
• spacing sizes: when presets are defined at the block level, both general top spacing sizes and the block level ones are displayed