mirrored from git://develop.git.wordpress.org/
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic to sort posts by hierarchy #8014
Open
oandregal
wants to merge
7
commits into
WordPress:trunk
Choose a base branch
from
oandregal:add/post-controller-hierarchy
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+379
−0
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e1545b5
Add logic to sort posts by hierarchy
oandregal 09fb57b
Declare orderby_hierarchy in post controller test
oandregal 48b3a53
Update wp-api-generated fixture
oandregal cd2f956
Do not use filters
oandregal a6000fc
Use class directly and remove static cache
oandregal b4a54ef
Fix PHP lint issues
oandregal ec420bb
Update unit tests to latest changes
oandregal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,141 @@ | ||
<?php | ||
|
||
/** | ||
* Implements sorting posts by parent-child relationship. | ||
* | ||
* @package WordPress | ||
* @since 6.8.0 | ||
*/ | ||
|
||
/** | ||
* Sort post by hierarchy (parent-child relationship). | ||
* | ||
* @since 6.8.0 | ||
*/ | ||
class Hierarchical_Sort { | ||
|
||
/** | ||
* Check if the request is eligible for hierarchical sorting. | ||
* | ||
* @param array $request The request data. | ||
* | ||
* @return bool Return true if the request is eligible for hierarchical sorting. | ||
*/ | ||
public static function is_eligible( $request ) { | ||
if ( ! isset( $request['orderby_hierarchy'] ) || true !== $request['orderby_hierarchy'] ) { | ||
return false; | ||
} | ||
|
||
return true; | ||
} | ||
|
||
public static function run( $args ) { | ||
$new_args = array_merge( | ||
$args, | ||
array( | ||
'fields' => 'id=>parent', | ||
'posts_per_page' => -1, | ||
) | ||
); | ||
$query = new WP_Query( $new_args ); | ||
$posts = $query->posts; | ||
|
||
return self::sort( $posts ); | ||
} | ||
|
||
private static function get_ancestor( $post_id ) { | ||
return get_post( $post_id )->post_parent ?? 0; | ||
} | ||
|
||
/** | ||
* Sort posts by hierarchy. | ||
* | ||
* Takes an array of posts and sorts them based on their parent-child relationships. | ||
* It also tracks the level depth of each post in the hierarchy. | ||
* | ||
* Example input: | ||
* ``` | ||
* [ | ||
* ['ID' => 4, 'post_parent' => 2], | ||
* ['ID' => 2, 'post_parent' => 0], | ||
* ['ID' => 3, 'post_parent' => 2], | ||
* ] | ||
* ``` | ||
* | ||
* Example output: | ||
* ``` | ||
* [ | ||
* 'post_ids' => [2, 4, 3], | ||
* 'levels' => [0, 1, 1] | ||
* ] | ||
* ``` | ||
* | ||
* @param array $posts Array of post objects containing ID and post_parent properties. | ||
* | ||
* @return array { | ||
* Sorted post IDs and their hierarchical levels | ||
* | ||
* @type array $post_ids Array of post IDs | ||
* @type array $levels Array of levels for the corresponding post ID in the same index | ||
* } | ||
*/ | ||
private static function sort( $posts ) { | ||
/* | ||
* Arrange pages in two arrays: | ||
* | ||
* - $top_level: posts whose parent is 0 | ||
* - $children: post ID as the key and an array of children post IDs as the value. | ||
* Example: $children[10][] contains all sub-pages whose parent is 10. | ||
* | ||
* Additionally, keep track of the levels of each post in $levels. | ||
* Example: $levels[10] = 0 means the post ID is a top-level page. | ||
* | ||
*/ | ||
$top_level = array(); | ||
$children = array(); | ||
foreach ( $posts as $post ) { | ||
if ( empty( $post->post_parent ) ) { | ||
$top_level[] = $post->ID; | ||
} else { | ||
$children[ $post->post_parent ][] = $post->ID; | ||
} | ||
} | ||
|
||
$ids = array(); | ||
$levels = array(); | ||
self::add_hierarchical_ids( $ids, $levels, 0, $top_level, $children ); | ||
|
||
// Process remaining children. | ||
if ( ! empty( $children ) ) { | ||
foreach ( $children as $parent_id => $child_ids ) { | ||
$level = 0; | ||
$ancestor = $parent_id; | ||
while ( 0 !== $ancestor ) { | ||
++$level; | ||
$ancestor = self::get_ancestor( $ancestor ); | ||
} | ||
self::add_hierarchical_ids( $ids, $levels, $level, $child_ids, $children ); | ||
} | ||
} | ||
|
||
return array( | ||
'post_ids' => $ids, | ||
'levels' => $levels, | ||
); | ||
} | ||
|
||
private static function add_hierarchical_ids( &$ids, &$levels, $level, $to_process, $children ) { | ||
foreach ( $to_process as $id ) { | ||
if ( in_array( $id, $ids, true ) ) { | ||
continue; | ||
} | ||
$ids[] = $id; | ||
$levels[ $id ] = $level; | ||
|
||
if ( isset( $children[ $id ] ) ) { | ||
self::add_hierarchical_ids( $ids, $levels, $level + 1, $children[ $id ], $children ); | ||
unset( $children[ $id ] ); | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oandregal: Correct me if I'm wrong, but this is the same problem that we had with static variables in the original Gutenberg PR. The concept of posts controller doesn't map 1:1 to the concept of a query, and so attaching the state of a query (
levels
) to a controller instance that can outlive it ($this
) seems dangerous.