Global styles: preload user global styles based on user caps #7681
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Syncs WordPress/gutenberg#66541
For the Post Editor, preload
'/wp/v2/global-styles/' . $global_styles_id
with a context corresponding to user caps, that is,'edit'
for users that can edit global styles, and'view'
for everyone else.Why
Preloading the global styles endpoint according to role context means that admins and non admins, e.g., editors, avoid unnecessary clientside requests.
Different clientside requests fire for each.
How?
Use
current_user_can( 'edit_theme_options' )
to test for global styles edit caps. This matches post type caps.Testing Instructions
global-styles
endpoints aren't fetched client side, but are, rather, preloaded via rest_preload_api_requestFor admins in the POST and SITE editors the following URLS should be preloaded:
For editors in the POST editor:
Trac ticket: https://core.trac.wordpress.org/ticket/62322
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.