Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance update_option Functionality: Autoload Behavior Update and Documentation Improvements #7679

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

Debarghya-Banerjee
Copy link

Trac Ticket: Core-48393

Summary

  • This pull request introduces changes to the update_option function in WordPress, enhancing its functionality and updating the corresponding documentation.

Code Changes

Behavior Update:

  • If the user explicitly provides the $autoload parameter and it differs from the existing value, the autoload status will be updated even if the $value remains unchanged.

  • If both the $value and the $autoload parameters are the same as their existing values, the function will not perform an update.

  • When the $autoload parameter is set to null, it is assumed that the user has not provided a value for autoloading, and the decision to update will be based solely on the comparison of the old and new values.

Documentation Updates

  • The documentation has been revised to reflect the new behavior of the $autoload parameter:
    • Clarified that $autoload can be updated when explicitly provided and different from the existing value, even if the $value is unchanged.
    • Enhanced explanations for better understanding of how the $autoload and $value parameters interact during the update process.

Key Points

  • This change improves the flexibility of the update_option function, allowing for more granular control over option updates.

  • The documentation now accurately describes the behavior and implications of using the $autoload parameter.

Additional Notes

  • These updates aim to provide clearer guidance to developers on using the update_option function and to ensure that the behavior aligns with their expectations.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant