Allow application/json uploads when fileinfo detects them as text/plain#12165
Allow application/json uploads when fileinfo detects them as text/plain#12165himanshupathak95 wants to merge 2 commits into
application/json uploads when fileinfo detects them as text/plain#12165Conversation
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/54193
When the PHP
fileinfoextension is active, it occasionally misidentifies uploaded.jsonfiles (especially those with simple string structures) astext/plain. Becauseapplication/jsonwas not included in the fallback list of safe plain-text types inwp_check_filetype_and_ext(), these uploads were being falsely rejected.This PR resolves the issue by adding
application/jsonto the array of allowed types when the real MIME type is detected astext/plain. Since JSON is inherently a plain-text format, this is a secure, non-breaking fix that allows users to seamlessly upload JSON files, even on server environments with olderlibmagicdefinitions.