Skip to content

Include a single module.exports assignment#12157

Open
desrosj wants to merge 9 commits into
WordPress:trunkfrom
desrosj:fix/ttn-postcss-config
Open

Include a single module.exports assignment#12157
desrosj wants to merge 9 commits into
WordPress:trunkfrom
desrosj:fix/ttn-postcss-config

Conversation

@desrosj

@desrosj desrosj commented Jun 11, 2026

Copy link
Copy Markdown
Member

This combines the two module.exports assignments to ensure that all desired plugins are run.

This also runs npx update-browserslist-db@latest to ensure the latest browser data is available.

Trac ticket: Core-65452.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 4.7
Used for: PR created with Claude and reviewed by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this Jun 11, 2026
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Twenty Nineteen theme’s PostCSS configuration so both postcss-focus-within and autoprefixer run (by exporting a single module.exports), then updates Browserslist data and regenerates the compiled theme CSS to reflect current prefixing requirements.

Changes:

  • Consolidate postcss.config.js to a single export and ensure autoprefixer is actually executed.
  • Refresh Browserslist-related lockfile entries (e.g., baseline-browser-mapping, caniuse-lite) consistent with running npx update-browserslist-db@latest.
  • Update generated CSS outputs to add/remove vendor-prefixed declarations based on the current Browserslist data.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/wp-content/themes/twentynineteen/style.css Regenerated compiled CSS with updated autoprefixing output.
src/wp-content/themes/twentynineteen/style-rtl.css Regenerated RTL compiled CSS with updated autoprefixing output.
src/wp-content/themes/twentynineteen/style-editor.css Regenerated editor compiled CSS reflecting updated prefix removal.
src/wp-content/themes/twentynineteen/postcss.config.js Combines duplicate exports and ensures both PostCSS plugins run.
src/wp-content/themes/twentynineteen/package-lock.json Updates Browserslist data dependencies after DB refresh.
Files not reviewed (1)
  • src/wp-content/themes/twentynineteen/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/wp-content/themes/twentynineteen/style.css Outdated
Comment thread src/wp-content/themes/twentynineteen/style-rtl.css Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants