-
Notifications
You must be signed in to change notification settings - Fork 123
Conversation
Like I said somewhere else (I totally lost where), we probably should discuss the naming of some of these templates. They make sense to me for things like the home page, where the concept of portfolio/writer/business is more apparent because of the content we've chosen to showcase. But when it comes to page/single, we are talking about the user's content, and to me it feels much less confusing and informative to be descriptive about what the template looks like. In this case Page with sidebar conveys much more to me than Page Writer, and it let's me know easily when I'm creating a page if this is the template I need to switch to when I want my page to have just that, a sidebar. Opinions? @richtabor @beafialho |
Maybe it should just be a neutral page pattern without the writer footer? |
good question |
Yes, I'm thinking headers and footers should be consistent across templates — that way if replaced in the template part flow, the changes persist across templates. Otherwise you'd have multiple headers, unintentionally. |
Agree on the "Page With Sidebar" conveying more, as it can be used well throughout all three cases, but for the others (Archives, Search, Posts) Entrepreneur, Photographer and Writer make sense because they're descriptive and suggestive. If I read "Photographer Archive", I imagine it's designed to be image focused, and if I read "Writer Archive" I assume it's designed to feature mostly text. Another advantage of naming them similarly is it becomes a hint that if you use the "Photographer Archive" template with the "Photographer Footer", your site will probably look more cohesive, and so on. That said though, if we agree on naming them all more literally, I'm open to suggestions. |
|
||
<!-- wp:column {"width":"30%"} --> | ||
<div class="wp-block-column" style="flex-basis:30%"> | ||
<!-- wp:template-part {"slug":"sidebar"} /--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! #408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the page templates don't display the post meta, next and previous post, and has no comment form. |
Good point. Bummer we have nearly duplicative templates. :/ |
Yeah its a shame we can't use more conditions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Re-adds the page with sidebar template.
This template and the sidebar pattern will need several iterations to spacing and to fix accessibility issues.
Only the "writer" design has a page with sidebar so I am not sure that this is correct.
There is a page template with sidebar listed here: #9
Figma: https://www.figma.com/file/AlYr03vh4dVimwYwQkTdf6/Twenty-Twenty-Four?node-id=511%3A1757&mode=dev
Screenshots
Testing Instructions
Select or create a new page.
In the block editor, in the Page panel, select template and choose "Page with Sidebar"
Save.
View the page on the front.