Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for integrating and extending #125

Closed
wants to merge 25 commits into from
Closed

Conversation

ashfame
Copy link
Member

@ashfame ashfame commented Nov 22, 2024

This PR provides a WordPress-y API for integrating with data liberation.

See Rendered documentation

Apart from that, it has all the code changes required to support the behavior as per documentation along with some improvements. Can be reviewed commit by commit.

In a follow up PR, I can add tests for Subject and Subject_Repo class.

Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I don't have any specific objections, and given there's already PRs that address some of the feedback, approving 👌

…_setting

Abstract the act of storing references to Subject class
@psrpinto psrpinto mentioned this pull request Dec 5, 2024
@ashfame ashfame mentioned this pull request Dec 20, 2024
@ashfame
Copy link
Member Author

ashfame commented Jan 7, 2025

Closing as this was handled in sub-issues of #139

@ashfame ashfame closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants