-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for unsupported plugin name in plugin header field #825
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Tests are failing due to unrelated issue with this PR. Edit: Tests are passing now. |
54a8faa
to
4297bec
Compare
4297bec
to
e239e48
Compare
@frantorres has suggested to modify the conditional and make less strict. Like: Check if plugin name "has at least 5 latin letters (A-z), numbers, spaces, and hyphens" and not worry if there are other non valid characters around. |
I think that you meant @frantorres |
I have updated the conditional to make less strict. Current message looks off after new conditional:
Can you please suggest updated message? |
Maybe
|
Fixes #805