Add separate license error codes for Plugin Header #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernilambar
force-pushed
the
separate-license-error-codes
branch
from
2c8be26 to
79c10db
Compare
ernilambar
commented
Nov 7, 2024
| @@ -192,24 +192,6 @@ public function test_run_without_error_mpl2_license() { | |||
| $this->assertEmpty( $errors ); | |||
| } | |||
|
|
|||
| public function test_run_with_errors_mpl1_license() { | |||
There was a problem hiding this comment.
This has been removed as it was checking license value from plugin header. The same plugin is used in test_run_with_invalid_mpl1_license (in Plugin_Header_Fields_Check_Tests) for checking for invalid license.
ernilambar
requested review from
barrykooij,
davidperezgar,
frantorres and
chriscct7
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ernilambar
added
[Team] Plugin Review
davidperezgar
approved these changes
Nov 7, 2024
frantorres
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements second part of #762
Add two error codes:
Now, error codes
no_licenseandinvalid_licenserefers only to the license check in readme.