Repository navigation
Single file plugin text domain check yields mixed and incorrect expected strings #745
Description
Activity
May be if we bail the runner in
Abstract_PHP_CodeSniffer_Checkif$this->get_args( $result )is empty array. This way we can pass args based on single file plugin or multiple file plugin.CC @swissspidy
Sorry, why is that array empty for single-file plugins?
We do have special handling for single-file plugins in many places, I suppose this is just one more place we‘d need to fix.
For check extended from
Abstract_PHP_CodeSniffer_Check, onlyget_args()method is exposed. I could not find place to add is_single_file_plugin() conditional for such check likeI18n_Usage_Check.Trying to solve this in
I18n_Usage_Checkis the wrong place. The big issue is that admin & CLI expect a different plugin slug. And both of them are incorrect.
For a single file plugin with a text domain set, the
WordPress.WP.I18n.TextDomainMismatchcheck relies on a plugin directory slug (non-existent in this context) and shows different results between the UI and CLI. It has been suggested that this check be bypassed for single-file plugins (hat tip @ernilambar).To test this, I added the
hello-dollytext domain to thehello.phpplugin that ships with WP core (required to avoid an error with theWordPress.WP.I18n.MissingArgDomaincheck):Running PCP, the admin shows
Mismatched text domain. Expected 'plugins' but got 'hello-dolly'.whereas the CLI returns
Mismatched text domain. Expected 'hello.php' but got 'hello-dolly'.Originally reported at #713 (comment).