-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format existing code files and exclude playground/vendor #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was running into this when working on #161 this morning.
Is there a reason we don't run a linter in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sejas!
@sejas should we move the packages/playground/phpcs.xml file to the root folder? |
Yes, I think it makes sense to have a unique phpcs.xml at the root directory. I moved it here 7073a53
The project is not 100% well configured and the linter doesn't throw any error, but prettier format the files. I also added |
What?
On #154 we added the playground plugin with multiple vendor files that
npx nx format
was formatting after each push.This PR format existing code files and excludes those in vendor.
.nx/cahce
from gitpackage/playground/phpcs.xml
to the root directoryWhy?
It's better to keep consistency with formatting tools.
How?
I executed
npx nx format
.Testing Instructions