Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit element node index in XPaths up to children of BODY #1790

Merged
merged 6 commits into from
Jan 13, 2025
Merged

Omit element node index in XPaths up to children of BODY #1790

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f264937
Eliminate node index from first three levels of XPath
westonruter Jan 10, 2025
ec95b09
Automatically convert old XPath scheme
westonruter Jan 10, 2025
9406484
Improve XPath pattern and construction
westonruter Jan 13, 2025
e840bdd
Update test cases to reflect new XPaths
westonruter Jan 13, 2025
cd8712b
Merge branch 'trunk' into update/xpath-construction
westonruter Jan 13, 2025
aa07c71
Elaborate on rationale for XPath omitting node index on children of BODY
westonruter Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/embed-optimizer/class-embed-optimizer-tag-visitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ public function __invoke( OD_Tag_Visitor_Context $context ): bool {
*
* @since 0.3.0
*
* @param string $embed_block_xpath XPath for the embed block FIGURE tag. For example: `/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]`.
* @return string XPath for the child DIV. For example: `/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]`
* @param string $embed_block_xpath XPath for the embed block FIGURE tag. For example: `/HTML/BODY/DIV/*[1][self::FIGURE]`.
* @return string XPath for the child DIV. For example: `/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]`
*/
private static function get_embed_wrapper_xpath( string $embed_block_xpath ): string {
return $embed_block_xpath . '/*[1][self::DIV]';
Expand Down
90 changes: 45 additions & 45 deletions plugins/embed-optimizer/tests/test-cases/all-embeds-inside-viewport/expected.html
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion plugins/embed-optimizer/tests/test-cases/all-embeds-inside-viewport/set-up.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
$elements[] = array_merge(
$element_data,
array(
'xpath' => "/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[{$i}][self::FIGURE]/*[1][self::DIV]",
'xpath' => "/HTML/BODY/DIV/*[{$i}][self::FIGURE]/*[1][self::DIV]",
)
);
}
Expand Down
18 changes: 9 additions & 9 deletions plugins/embed-optimizer/tests/test-cases/nested-figure-embed/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
<meta charset="utf-8">
<title>...</title>
<style>
@media (max-width: 480px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 783px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (max-width: 480px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 783px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
</style>
<style>
@media (max-width: 480px) { #existing-figurine-id { min-height: 654px; } }
Expand All @@ -18,16 +18,16 @@
</head>
<body>
<div class="wp-site-blocks">
<figure data-od-added-id id="embed-optimizer-c2b6b833aecac76a3a42d55f197c806a" style="background: black; color:gray" class="wp-block-embed is-type-video">
<div data-od-xpath="/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]" class="wp-block-embed__wrapper">
<video data-od-added-preload data-od-xpath="/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]/*[1][self::VIDEO]" preload="auto" src="https://example.com/video1.mp4" poster="https://example.com/poster1.jpg" width="640" height="480"></video>
<figure data-od-added-id id="embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b" style="background: black; color:gray" class="wp-block-embed is-type-video">
<div data-od-xpath="/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]" class="wp-block-embed__wrapper">
<video data-od-added-preload data-od-xpath="/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]/*[1][self::VIDEO]" preload="auto" src="https://example.com/video1.mp4" poster="https://example.com/poster1.jpg" width="640" height="480"></video>
</div>
</figure>
<figure id="existing-figurine-id" class="wp-block-embed is-type-rich is-provider-figurine wp-block-embed-figurine">
<div data-od-xpath="/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[2][self::FIGURE]/*[1][self::DIV]" class="wp-block-embed__wrapper">
<div data-od-xpath="/HTML/BODY/DIV/*[2][self::FIGURE]/*[1][self::DIV]" class="wp-block-embed__wrapper">
<figure>
<p>So I heard you like <code>FIGURE</code>?</p>
<video data-od-added-preload data-od-xpath="/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[2][self::FIGURE]/*[1][self::DIV]/*[1][self::FIGURE]/*[2][self::VIDEO]" preload="none" src="https://example.com/video2.mp4" poster="https://example.com/poster2.jpg" width="640" height="480"></video>
<video data-od-added-preload data-od-xpath="/HTML/BODY/DIV/*[2][self::FIGURE]/*[1][self::DIV]/*[1][self::FIGURE]/*[2][self::VIDEO]" preload="none" src="https://example.com/video2.mp4" poster="https://example.com/poster2.jpg" width="640" height="480"></video>
<figcaption>Tagline from Figurine embed.</figcaption>
</figure>
<iframe data-od-added-loading loading="lazy" src="https://example.com/" width="640" height="480"></iframe>
Expand Down
8 changes: 4 additions & 4 deletions plugins/embed-optimizer/tests/test-cases/nested-figure-embed/set-up.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,24 @@
$test_case->populate_url_metrics(
array(
array(
'xpath' => '/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]',
'xpath' => '/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]',
'isLCP' => false,
'intersectionRatio' => 1,
'resizedBoundingClientRect' => array_merge( $test_case->get_sample_dom_rect(), array( 'height' => 500 ) ),
),
array(
'xpath' => '/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]/*[1][self::VIDEO]',
'xpath' => '/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]/*[1][self::VIDEO]',
'isLCP' => false,
'intersectionRatio' => 1,
),
array(
'xpath' => '/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[2][self::FIGURE]/*[1][self::DIV]',
'xpath' => '/HTML/BODY/DIV/*[2][self::FIGURE]/*[1][self::DIV]',
'isLCP' => false,
'intersectionRatio' => 0,
'resizedBoundingClientRect' => array_merge( $test_case->get_sample_dom_rect(), array( 'height' => 654 ) ),
),
array(
'xpath' => '/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[2][self::FIGURE]/*[1][self::DIV]/*[1][self::FIGURE]/*[2][self::VIDEO]',
'xpath' => '/HTML/BODY/DIV/*[2][self::FIGURE]/*[1][self::DIV]/*[1][self::FIGURE]/*[2][self::VIDEO]',
'isLCP' => false,
'intersectionRatio' => 0,
),
Expand Down
12 changes: 6 additions & 6 deletions ...sts/test-cases/single-spotify-embed-outside-viewport-with-subsequent-script/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@
<meta charset="utf-8">
<title>...</title>
<style>
@media (max-width: 480px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 783px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (max-width: 480px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 783px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
</style>
</head>
<body>
<div class="wp-site-blocks">
<figure data-od-added-id id="embed-optimizer-c2b6b833aecac76a3a42d55f197c806a" class="wp-block-embed is-type-rich is-provider-spotify wp-block-embed-spotify wp-embed-aspect-21-9 wp-has-aspect-ratio">
<div data-od-xpath="/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]" class="wp-block-embed__wrapper">
<figure data-od-added-id id="embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b" class="wp-block-embed is-type-rich is-provider-spotify wp-block-embed-spotify wp-embed-aspect-21-9 wp-has-aspect-ratio">
<div data-od-xpath="/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]" class="wp-block-embed__wrapper">
<iframe data-od-added-loading loading="lazy" title="Spotify Embed: Deep Focus" style="border-radius: 12px" width="100%" height="352" frameborder="0" allowfullscreen allow="autoplay; clipboard-write; encrypted-media; fullscreen; picture-in-picture" src="https://open.spotify.com/embed/playlist/37i9dQZF1DWZeKCadgRdKQ?utm_source=oembed"></iframe>
</div>
</figure>
Expand Down
2 changes: 1 addition & 1 deletion .../tests/test-cases/single-spotify-embed-outside-viewport-with-subsequent-script/set-up.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
$test_case->populate_url_metrics(
array(
array(
'xpath' => '/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]',
'xpath' => '/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]',
'isLCP' => false,
'intersectionRatio' => 0,
'resizedBoundingClientRect' => array_merge( $test_case->get_sample_dom_rect(), array( 'height' => 500 ) ),
Expand Down
2 changes: 1 addition & 1 deletion ...zer/tests/test-cases/single-twitter-embed-inside-viewport-without-resized-data/set-up.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
$test_case->populate_url_metrics(
array(
array(
'xpath' => '/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]',
'xpath' => '/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]',
'isLCP' => true,
'intersectionRatio' => 1,
// Intentionally omitting resizedBoundingClientRect here to test behavior when data isn't supplied.
Expand Down
10 changes: 5 additions & 5 deletions plugins/embed-optimizer/tests/test-cases/single-twitter-embed-inside-viewport/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@
<meta charset="utf-8">
<title>...</title>
<style>
@media (max-width: 480px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 783px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (max-width: 480px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 783px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
</style>
<link data-od-added-tag rel="preconnect" href="https://pbs.twimg.com">
<link data-od-added-tag rel="preconnect" href="https://syndication.twitter.com">
</head>
<body>
<div class="wp-site-blocks">
<figure data-od-added-id id="embed-optimizer-c2b6b833aecac76a3a42d55f197c806a" class="wp-block-embed is-type-rich is-provider-twitter wp-block-embed-twitter">
<figure data-od-added-id id="embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b" class="wp-block-embed is-type-rich is-provider-twitter wp-block-embed-twitter">
<div class="wp-block-embed__wrapper">
<blockquote class="twitter-tweet" data-width="550" data-dnt="true"><p lang="en" dir="ltr">We want your feedback for the Privacy Sandbox 📨<br><br>Learn why your feedback is critical through real examples and learn how to provide it ↓ <a href="https://t.co/anGk6gWkbc">https://t.co/anGk6gWkbc</a></p>&mdash; Chrome for Developers (@ChromiumDev) <a href="https://twitter.com/ChromiumDev/status/1636796541368139777?ref_src=twsrc%5Etfw">March 17, 2023</a></blockquote>
<script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>
Expand Down
2 changes: 1 addition & 1 deletion plugins/embed-optimizer/tests/test-cases/single-twitter-embed-inside-viewport/set-up.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
$test_case->populate_url_metrics(
array(
array(
'xpath' => '/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]',
'xpath' => '/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]',
'isLCP' => true,
'intersectionRatio' => 1,
'resizedBoundingClientRect' => array_merge( $test_case->get_sample_dom_rect(), array( 'height' => 500 ) ),
Expand Down
10 changes: 5 additions & 5 deletions ...-optimizer/tests/test-cases/single-twitter-embed-outside-viewport-on-mobile/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@
<meta charset="utf-8">
<title>...</title>
<style>
@media (max-width: 480px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 600px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 700px; } }
@media (min-width: 783px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 800px; } }
@media (max-width: 480px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 600px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 700px; } }
@media (min-width: 783px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 800px; } }
</style>
<link data-od-added-tag rel="preconnect" href="https://pbs.twimg.com" media="(min-width: 481px)">
<link data-od-added-tag rel="preconnect" href="https://syndication.twitter.com" media="(min-width: 481px)">
</head>
<body>
<div class="wp-site-blocks">
<figure data-od-added-id id="embed-optimizer-c2b6b833aecac76a3a42d55f197c806a" class="wp-block-embed is-type-rich is-provider-twitter wp-block-embed-twitter">
<figure data-od-added-id id="embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b" class="wp-block-embed is-type-rich is-provider-twitter wp-block-embed-twitter">
<div class="wp-block-embed__wrapper">
<blockquote class="twitter-tweet" data-width="550" data-dnt="true"><p lang="en" dir="ltr">We want your feedback for the Privacy Sandbox 📨<br><br>Learn why your feedback is critical through real examples and learn how to provide it ↓ <a href="https://t.co/anGk6gWkbc">https://t.co/anGk6gWkbc</a></p>&mdash; Chrome for Developers (@ChromiumDev) <a href="https://twitter.com/ChromiumDev/status/1636796541368139777?ref_src=twsrc%5Etfw">March 17, 2023</a></blockquote>
<script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>
Expand Down
2 changes: 1 addition & 1 deletion ...bed-optimizer/tests/test-cases/single-twitter-embed-outside-viewport-on-mobile/set-up.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
foreach ( array_merge( od_get_breakpoint_max_widths(), array( 1000 ) ) as $i => $viewport_width ) {
$elements = array(
array(
'xpath' => '/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]',
'xpath' => '/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]',
'isLCP' => true,
'resizedBoundingClientRect' => array_merge( $test_case->get_sample_dom_rect(), array( 'height' => 500 + $i * 100 ) ),
),
Expand Down
10 changes: 5 additions & 5 deletions plugins/embed-optimizer/tests/test-cases/single-twitter-embed-outside-viewport/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
<meta charset="utf-8">
<title>...</title>
<style>
@media (max-width: 480px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 783px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (max-width: 480px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 783px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
</style>
</head>
<body>
<div class="wp-site-blocks">
<figure data-od-added-id id="embed-optimizer-c2b6b833aecac76a3a42d55f197c806a" class="wp-block-embed is-type-rich is-provider-twitter wp-block-embed-twitter">
<figure data-od-added-id id="embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b" class="wp-block-embed is-type-rich is-provider-twitter wp-block-embed-twitter">
<div class="wp-block-embed__wrapper">
<blockquote class="twitter-tweet" data-width="550" data-dnt="true"><p lang="en" dir="ltr">We want your feedback for the Privacy Sandbox 📨<br><br>Learn why your feedback is critical through real examples and learn how to provide it ↓ <a href="https://t.co/anGk6gWkbc">https://t.co/anGk6gWkbc</a></p>&mdash; Chrome for Developers (@ChromiumDev) <a href="https://twitter.com/ChromiumDev/status/1636796541368139777?ref_src=twsrc%5Etfw">March 17, 2023</a></blockquote>
<script data-od-added-type type="application/vnd.embed-optimizer.javascript" async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>
Expand Down
2 changes: 1 addition & 1 deletion plugins/embed-optimizer/tests/test-cases/single-twitter-embed-outside-viewport/set-up.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
$test_case->populate_url_metrics(
array(
array(
'xpath' => '/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]',
'xpath' => '/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]',
'isLCP' => false,
'intersectionRatio' => 0,
'resizedBoundingClientRect' => array_merge( $test_case->get_sample_dom_rect(), array( 'height' => 500 ) ),
Expand Down
12 changes: 6 additions & 6 deletions .../embed-optimizer/tests/test-cases/single-wordpress-tv-embed-inside-viewport/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
<meta charset="utf-8">
<title>...</title>
<style>
@media (max-width: 480px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (min-width: 783px) { #embed-optimizer-c2b6b833aecac76a3a42d55f197c806a { min-height: 500px; } }
@media (max-width: 480px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 481px) and (max-width: 600px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 601px) and (max-width: 782px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
@media (min-width: 783px) { #embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b { min-height: 500px; } }
</style>
<link data-od-added-tag rel="preconnect" href="https://public-api.wordpress.com">
<link data-od-added-tag rel="preconnect" href="https://v0.wordpress.com">
Expand All @@ -15,8 +15,8 @@
</head>
<body>
<div class="wp-site-blocks">
<figure data-od-added-id id="embed-optimizer-c2b6b833aecac76a3a42d55f197c806a" class="wp-block-embed is-type-video is-provider-wordpress-tv wp-block-embed-wordpress-tv wp-embed-aspect-16-9 wp-has-aspect-ratio">
<div data-od-xpath="/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]" class="wp-block-embed__wrapper">
<figure data-od-added-id id="embed-optimizer-b4fa815eb0a365ecd43611413ae0a83b" class="wp-block-embed is-type-video is-provider-wordpress-tv wp-block-embed-wordpress-tv wp-embed-aspect-16-9 wp-has-aspect-ratio">
<div data-od-xpath="/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]" class="wp-block-embed__wrapper">
<iframe title="VideoPress Video Player" aria-label='VideoPress Video Player' width='750' height='422' src='https://video.wordpress.com/embed/vaWm9zO6?hd=1&amp;cover=1' frameborder='0' allowfullscreen allow='clipboard-write'></iframe>
<script src='https://v0.wordpress.com/js/next/videopress-iframe.js?m=1674852142'></script>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ...ins/embed-optimizer/tests/test-cases/single-wordpress-tv-embed-inside-viewport/set-up.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
$test_case->populate_url_metrics(
array(
array(
'xpath' => '/*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::DIV]',
'xpath' => '/HTML/BODY/DIV/*[1][self::FIGURE]/*[1][self::DIV]',
'isLCP' => true,
'intersectionRatio' => 1,
'resizedBoundingClientRect' => array_merge( $test_case->get_sample_dom_rect(), array( 'height' => 500 ) ),
Expand Down
Loading
Loading