Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Site Health test to verify that static assets are served with far-future expires #1727

Open
wants to merge 22 commits into
base: trunk
Choose a base branch
from

Merge branch 'trunk' into add/far-future-expiration-test

ed28196
Select commit
Loading
Failed to load commit list.
Open

Add Site Health test to verify that static assets are served with far-future expires #1727

Merge branch 'trunk' into add/far-future-expiration-test
ed28196
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2025 in 0s

58.05% (+0.56%) compared to b6e5c5a

View this Pull Request on Codecov

58.05% (+0.56%) compared to b6e5c5a

Details

Codecov Report

Attention: Patch coverage is 78.65169% with 38 lines in your changes missing coverage. Please review.

Project coverage is 58.05%. Comparing base (b6e5c5a) to head (ed28196).

Files with missing lines Patch % Lines
...includes/site-health/far-future-headers/helper.php 83.33% 28 Missing ⚠️
.../includes/site-health/far-future-headers/hooks.php 0.00% 8 Missing ⚠️
...gins/performance-lab/includes/site-health/load.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #1727      +/-   ##
==========================================
+ Coverage   57.48%   58.05%   +0.56%     
==========================================
  Files          84       86       +2     
  Lines        6516     6694     +178     
==========================================
+ Hits         3746     3886     +140     
- Misses       2770     2808      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.