-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creator: Add welcome guide on first load. #97
Conversation
@shaunandrews Do you think it's realistic we will get a "Learn More" page before launching?... Just considering whether this PR should wait for it or comment out the last view and try to merge in the meantime. |
You can comment it out for now if you want. I think the "Learn more" page could just be a page on the directory, like wordpress.org/patterns/guide and the content will likely be simple to start; A list of do's and don'ts and a few tips. Here's a draft I've worked up:
|
@shaunandrews Right on. That's looking good but I'll comment it out for now since it could get caught up in a few iterations. |
After commenting it out and using the guide, It feels like it's missing something about the publishing step? Have we considered some content explaining that patterns need publishing to be shared? It's implied in the "find your patterns" panel but maybe we should consider being more explicit? Currently:
Maybe we do, maybe we don't. Thoughts? |
An earlier iteration of the welcome design had a slide about submitting patterns: I removed it because I thought the number of steps was getting too large. But I think we can probably replace the "Find your patterns..." one with the above step. That'd give us a welcome tour with the following steps: |
6061139
to
fd1a270
Compare
Is this PR still in progress, depending on #115, or is it ready for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The editor crashes when I try to load it, so i think this'll need to be rebased after #115 merges. I gave a quick look through the code though, and it seems fine.
public_html/wp-content/plugins/pattern-creator/src/components/welcome-guide/index.js
Outdated
Show resolved
Hide resolved
Conflicts resolved in: public_html/wp-content/plugins/pattern-creator/package.json yarn.lock
@ryelle This has been integrated now. A couple of differences with the designs:
|
Yes, added.
I was able to remove the What features are left that can't be supported? The preferences appear to be pretty timid and still more or less applicable? |
Some of them are probably fine to keep, but others need to be removed. The pre-publish checklist is being replaced with our modal, so this option will need to go. The whole Panels section will probably need to go, too. There's a blank setting, and the Template setting doesn't actually appear. The Custom fields option is broken, but also seems unrelated to the pattern editor. -- As for the tools section of the menu, I think some of these could be helpful. Keyboard Shortcuts, Copy All Content, and Welcome Guide (our variant in the issue) should probably remain available. I could see Help being updated to point to a relevant support page. |
We'd need to replace the welcome guide to make it work with ours, otherwise it will toggle the core one. Same with Help, we probably can't control that link. We could add a new list with our own menu items though. |
Correct. All the Additionally, there isn't a way to turn off specific toggles in the Regarding the empty and template panels, those can be removed (the empty one is weird.. hmmm). Custom fields are not a great feature to keep but are non-breaking. Now I'm obviously taking the position that we can work with it because there isn't a great way to create our own dropdown. The more menu is only hideable via css and we would have to render a new root component in the menu to have a dropdown and that's not an ideal setup. I'll hold off until we have a consensus. @ryelle @shaunandrews Thoughts? |
I moved the menu & preference discussion over to #192. @StevenDufresne, if you revert the menu changes here, we can probably merge this PR. |
Yep, I removed the code that turns off the tools. |
Fix conflicts in: pattern-creator/package.json pattern-creator/src/style.css
@ryelle Can I get some eyes back on this? |
This PR closes #96, adding a welcome guide for new users.
I have added the component into the current Creator which will most likely be changed when #59 is resolved. I think it's fine to implement it here and then move it over later.
To Do:
This needs integration with the final
pattern-creator
.Screenshots
How to test the changes in this Pull Request:
new-pattern
/new-pattern