This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Bump pytest from 6.2.4 to 6.2.5 in /ingestion_server #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/pip/ingestion_server/pytest-6.2.5
branch
3 times, most recently
from
ba0ef2b to
5c22da0
Compare
|
@dependabot rebase |
Bumps [pytest](https://github.com/pytest-dev/pytest) from 6.2.4 to 6.2.5. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@6.2.4...6.2.5) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/pip/ingestion_server/pytest-6.2.5
branch
from
5c22da0 to
961c9b1
Compare
|
I don't love that a version bump of one service affects several other unrelated ones in the |
|
@AetherUnbound I suppose it can happen if
For example, if Av1 depends on Bv1 and Av2 on Bv2, updating either A or B would require the other to be updated as well. |
|
In any case, passing tests are basically my go-to criteria for Dependabot PRs, as long as the major version hasn't changed. |
|
Sure, that makes sense. It looks like this PR is updating elasticsearch though - I don't believe pytest has any dependency on that |
|
I thought maybe ElasticSearch had a dependency on pytest or maybe they both had a dependency on something. None of that seems to be the case here. It's weird 🤷! |
|
That feels a bit concerning 😕 I don't know enough about pipenv to understand why dependabot would update two unrelated dependencies in one PR |
|
I am very unfamiliar with pipenv, so I might be doing something wrong. But I seem unable to update only one dependency using pipenv - it appears to update everything else it can: Is this typical behavior for pipenv? Is there something I'm missing? |
|
I found the issue:
So in this case, |
|
Wow, thank you for that excellent find @krysal! I tested this out, and it seems that you must specify the version you want to upgrade to (as you mention in your comment). Otherwise the command will complete without changing anything since you already have Command examples$ pipenv install --selective-upgrade pytest
Installing pytest...
Adding pytest to Pipfile's [packages]...
✔ Installation Succeeded
Installing dependencies from Pipfile.lock (e4d69b)...
🐍 ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 1/1 — 00:00:00
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
$ git diff
$ pipenv run pytest --version
pytest 6.2.4
$ pipenv install --selective-upgrade pytest==6.2.5
Installing pytest==6.2.5...
Adding pytest to Pipfile's [packages]...
✔ Installation Succeeded
Pipfile.lock (e4d69b) out of date, updating to (3e2039)...
Locking [dev-packages] dependencies...
Building requirements...
Resolving dependencies...
✔ Success!
Locking [packages] dependencies...
Building requirements...
Resolving dependencies...
✔ Success!
Updated Pipfile.lock (3e2039)!
Installing dependencies from Pipfile.lock (3e2039)...
🐍 ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 0/0 — 00:00:00
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
$ git diff
diff --git a/ingestion_server/Pipfile b/ingestion_server/Pipfile
index 6e339f4..fc78c7b 100644
--- a/ingestion_server/Pipfile
+++ b/ingestion_server/Pipfile
@@ -19,7 +19,7 @@ psycopg2-binary = "*"
PyYAML = "*"
boto3 = "*"
filelock = "*"
-pytest = "*"
+pytest = "==6.2.5"
tldextract = "*"
[requires]
diff --git a/ingestion_server/Pipfile.lock b/ingestion_server/Pipfile.lock
index f44dffb..aa43029 100644
--- a/ingestion_server/Pipfile.lock
+++ b/ingestion_server/Pipfile.lock
@@ -1,7 +1,7 @@
{
"_meta": {
"hash": {
- "sha256": "d371bdc9d6dfbfa5214b0508976b83320465c544ecb7a3c0f82cd46757e4d69b"
+ "sha256": "5b77a0eab3504d34b47b1c5c4dff1d2a84ebf795a9d2d5e2392321920d3e2039"
},
"pipfile-spec": 6,
"requires": {
@@ -241,7 +241,7 @@
"sha256:91ef2131a9bd6be8f76f1f08eac5c5317221d6ad1e143ae03894b862e8976890"
],
"index": "pypi",
- "version": "==6.2.4"
+ "version": "==6.2.5"
},
"python-dateutil": {
"hashes": [
$ pipenv run pytest --version
pytest 6.2.5The aggressive upgrade method doesn't seem ideal to me, but it seems to be how dependabot does it's version bumping 🤷♀️ |
|
Looks like pytest is up-to-date now, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/pip/ingestion_server/pytest-6.2.5
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps pytest from 6.2.4 to 6.2.5.
Release notes
Sourced from pytest's releases.
Commits
1569facFix CHANGELOG headera3599caPrepare release version 6.2.527613b8Merge pull request #9056 from nicoddemus/backport-9053cef74beMerge pull request #9053 from nicoddemus/change-8494-to-trivial83dc953Merge pull request #9051 from nicoddemus/backport-9047fb38e8dMerge pull request #9047 from nicoddemus/changelog-9040d74baf4Merge pull request #9042 from nicoddemus/backport-9040d9b8f7cBackport #889669212d1Merge pull request #8425 from RonnyPfannschmidt/main-fixes44d3282Merge pull request #9040 from nicoddemus/bump-pluggyDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)