Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign calendar frontend #159

Merged
merged 20 commits into from
Oct 14, 2024
Merged

Redesign calendar frontend #159

merged 20 commits into from
Oct 14, 2024

Conversation

adamwoodnz
Copy link
Collaborator

@adamwoodnz adamwoodnz commented Oct 9, 2024

Closes #158

Updates the layout and styles of the frontend to satisfy designs for Learn WordPress Online Workshops and Make WordPress meetings calendars.

For the Make team colors used in the calendar, care has been taken to ensure contrast ratios between background and text meet WCAG 2.1.

A notable difference between the Make and Learn designs lies in the calendar/list toggle buttons. See screenshots on the issue. I've opted to use the icon buttons shown in the Learn design.

Lastly an RSS feed has been added to the feed links, which have moved from the filter bar to the bottom of the calendar view.

NOTE: Does not include fixing existing broken unit tests, or styling for past events mentioned in #157. I think these should be done separately.

Screenshots

Make

Desktop Tablet Mobile
make wordpress org_meetings__new-theme=1 make wordpress org_meetings__new-theme=1(iPad) make wordpress org_meetings__new-theme=1(Samsung Galaxy S20 Ultra)

Learn

Desktop Tablet Mobile
learn wordpress org_online-workshops_ learn wordpress org_online-workshops_(iPad) learn wordpress org_online-workshops_(Samsung Galaxy S20 Ultra)

Testing

Best tested in sandbox.

  1. Load this branch of the plugin
  2. Test with Learn and Make
  3. For Learn load this branch as well
  4. For Make test with both the old theme and the new theme using the theme switcher
  5. Regression test all the things! Calendar view and event details modal, list view, team filter, feed links (GCal and ICS should be filtered when a team is selected), prev/next nav
  6. Test responsiveness
  7. Test a11y

@adamwoodnz adamwoodnz self-assigned this Oct 9, 2024
@adamwoodnz adamwoodnz force-pushed the update/158-redesign branch 6 times, most recently from 5470fac to 06ae8bf Compare October 10, 2024 05:17
@adamwoodnz adamwoodnz requested review from renintw and ryelle October 10, 2024 09:11
@adamwoodnz adamwoodnz marked this pull request as ready for review October 10, 2024 09:12
@adamwoodnz
Copy link
Collaborator Author

adamwoodnz commented Oct 10, 2024

@WordPress/meta-design your review would be appreciated too 🙏

I'll add more screenshots of the list view tomorrow 🇨🇦

@jasmussen
Copy link

Looks great, especially for a first version, contrasts pass and colors look good.

Screenshot 2024-10-10 at 14 04 36

Potentially the cell padding, or the event margin (whichever is in play) can be reduced, so the events are closer together in density, but there's also some value in the separation. Can start here, then tweak if need be.

{ // translators: %d: Count of all events, ie: 4.
sprintf(
{ sprintf(
// translators: %d: Count of all events, ie: 4.
Copy link
Collaborator Author

@adamwoodnz adamwoodnz Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint caught these problems with comments not being adjacent to translations

>
<Button
isSecondary
variant="secondary"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isSecondary is deprecated, variant is the new API, same goes for isLink and isPrimary

@adamwoodnz
Copy link
Collaborator Author

Screenshots

Make list view

Desktop Tablet Mobile
make wordpress org_meetings__new-theme=1(5 1440x900) (1) make wordpress org_meetings__new-theme=1(iPad) (1) make wordpress org_meetings__new-theme=1(Samsung Galaxy S20 Ultra) (1)

Make with old theme

Calendar List
make wordpress org_meetings__new-theme=0(5 1440x900) make wordpress org_meetings__new-theme=0(5 1440x900) (1)

@jasmussen
Copy link

Massive step forward.

@fcoveram
Copy link

It looks great 👏 🚀

@ryelle
Copy link
Collaborator

ryelle commented Oct 11, 2024

Applied on my sandbox and make/meetings looks great with the new theme 🎉

I found the old blue in a few places when previewing the new theme:

Screenshot 2024-10-11 at 5 41 19 PM Screenshot 2024-10-11 at 5 42 57 PM Screenshot 2024-10-11 at 6 01 31 PM

As far as a11y, I don't see any regressions. There are definitely things that could be improved, but they're current issues too. For example…

  • As you tab through the calendar view, there's no indication of which day you're on. I'm not sure what best practice would be here, and a quick search isn't helping much.
  • The list view day headings are not actually headings, so screen reader navigating through the page by heading levels also doesn't say which day things are.
  • There are empty links in the list view, since all items are wrapped in <a href={ event.link }> (not just an a11y issue)

But those could be future improvements, not blockers for this style update.

@adamwoodnz adamwoodnz changed the base branch from master to try/fix-php-unit-tests October 13, 2024 22:49
@adamwoodnz
Copy link
Collaborator Author

I found the old blue in a few places when previewing the new theme:

This'll be because I haven't shipped the components color vars in the new theme yet.

@adamwoodnz adamwoodnz force-pushed the update/158-redesign branch 2 times, most recently from 62ad999 to b476b7e Compare October 14, 2024 02:34
@adamwoodnz adamwoodnz force-pushed the try/fix-php-unit-tests branch from cf04821 to 5687712 Compare October 14, 2024 02:35
Base automatically changed from try/fix-php-unit-tests to master October 14, 2024 02:56
@adamwoodnz adamwoodnz force-pushed the update/158-redesign branch 3 times, most recently from a53b587 to d1ad970 Compare October 14, 2024 03:02
@adamwoodnz
Copy link
Collaborator Author

  • The list view day headings are not actually headings, so screen reader navigating through the page by heading levels also doesn't say which day things are.

Fixed in 1e2bae1

@adamwoodnz
Copy link
Collaborator Author

  • There are empty links in the list view, since all items are wrapped in <a href={ event.link }> (not just an a11y issue)

Fixed in e25bce0

@adamwoodnz adamwoodnz merged commit a846ed6 into master Oct 14, 2024
3 checks passed
@adamwoodnz adamwoodnz deleted the update/158-redesign branch October 14, 2024 22:07
>
<Button
isSecondary

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • BQ Aquaris X5 Plus (See this post)
  • Huawei Mate 9 (See this post)
  • Samsung Galaxy S8 and S8+ (See this post and official specs which say "Location (GPS, Galileo, Glonass, BeiDou) *Galileo and BeiDou coverage may be limited.")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adb shell sh /storage/emulated/0/Android/data/moe.shizuku.privileged.api/start.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Redesign frontend
5 participants