-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign calendar frontend #159
Conversation
5470fac
to
06ae8bf
Compare
@WordPress/meta-design your review would be appreciated too 🙏 I'll add more screenshots of the list view tomorrow 🇨🇦 |
Looks great, especially for a first version, contrasts pass and colors look good. Potentially the cell padding, or the event margin (whichever is in play) can be reduced, so the events are closer together in density, but there's also some value in the separation. Can start here, then tweak if need be. |
{ // translators: %d: Count of all events, ie: 4. | ||
sprintf( | ||
{ sprintf( | ||
// translators: %d: Count of all events, ie: 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint caught these problems with comments not being adjacent to translations
> | ||
<Button | ||
isSecondary | ||
variant="secondary" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isSecondary
is deprecated, variant
is the new API, same goes for isLink
and isPrimary
Massive step forward. |
It looks great 👏 🚀 |
3dc3a4b
to
dca0710
Compare
75e22df
to
dc8e8a3
Compare
This'll be because I haven't shipped the components color vars in the new theme yet. |
62ad999
to
b476b7e
Compare
cf04821
to
5687712
Compare
a53b587
to
d1ad970
Compare
Override global h3 styles
d1ad970
to
1a462b4
Compare
Fixed in 1e2bae1 |
Fixed in e25bce0 |
> | ||
<Button | ||
isSecondary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- BQ Aquaris X5 Plus (See this post)
- Huawei Mate 9 (See this post)
- Samsung Galaxy S8 and S8+ (See this post and official specs which say "Location (GPS, Galileo, Glonass, BeiDou) *Galileo and BeiDou coverage may be limited.")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adb shell sh /storage/emulated/0/Android/data/moe.shizuku.privileged.api/start.sh
Closes #158
Updates the layout and styles of the frontend to satisfy designs for Learn WordPress Online Workshops and Make WordPress meetings calendars.
For the Make team colors used in the calendar, care has been taken to ensure contrast ratios between background and text meet WCAG 2.1.
A notable difference between the Make and Learn designs lies in the calendar/list toggle buttons. See screenshots on the issue. I've opted to use the icon buttons shown in the Learn design.
Lastly an RSS feed has been added to the feed links, which have moved from the filter bar to the bottom of the calendar view.
NOTE: Does not include fixing existing broken unit tests, or styling for past events mentioned in #157. I think these should be done separately.
Screenshots
Make
Learn
Testing
Best tested in sandbox.