Editor: Fix 'slug' editing in 'template-locked' mode #69516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
6 tasks
|
Size Change: +17 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
fix/editor-post-slug-editing
branch
from
792709f to
9607a6e
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Mar 11, 2025
Yes, I'm aware of that, but I haven't found the right solution yet. Conditionally using the The P.S. The template flash you see when changing the slug is technically the same as trying to swap the template, but it's not apparent. I'm not sure if we can communicate this from the slug popover. |
|
Maybe the default template needs to be stored somewhere the same way as a custom template is, if that means it does not have to resolve the template based on the slug. |
I think it still has to react to the slug change. Example: You start working on a draft page and then decide that it should use the Generally speaking, template lookup/resolution needs some improvements (related #64341 (comment)), but it's out of the scope of this PR. |
Mamaduka
added
the
Backport to WP 6.8 Beta/RC
|
Flaky tests detected in 7f49a0c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13781124502
|
t-hamano
approved these changes
Mar 11, 2025
|
Thanks for the feedback, everyone! |
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 11, 2025
* Editor: Fix 'slug' editing in 'template-locked' mode * Make isRenderingModeReady condition less restrictive * Fix typo
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: b1f984c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #69509.
PR fixes a regression in which editing a page slug causes the editor canvas to fully re-render, disrupting field editing.
Why?
The editor provider only starts rendering its contents based on two conditions:
isReadyandmode; both need to betruthyfor the contents to render.Previously, I made
isReadydependent on thehasTemplatecondition to avoid rendering mode flash and wait until the editor resolved the template. This introduced the problem - changing the slug also recalculates the template ID for the current page, togglingisReadyfrom true to false and back.How?
Rearrange conditions so that
isReadyandmodeare not recalculated when thehasTemplatevalue changes.P.S. I think the content "flash" became less noticeable after #69454.
Testing Instructions
post-onlymode. Posts use this mode by default.Note: I tested with CPU throttling, and content loading differences are more noticeable.
Testing Instructions for Keyboard
Same.
Screenshots or screencast
The loading screencasts are taken with CPU throttling - 4x slowdown.
Before
slug-editing-fix-before.mp4
After
slug-editing-fix-after.mp4