Fix site editor edit mode toggling and initial focus accessibility #69515
+157
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +11 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
This is probably obvious, but since its not mentioned in the description: With the button overlay, its not possible to scroll with mouse / touchpad / keyboard to see the full length of the preview. I can't see the whole template. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
afercia
force-pushed
the
fix/site-editor-edit-mode-initial-focus
branch
from
709a75f to
eee8ef7
Compare
|
In the last commit I've cleaned up things a little to preserve the scrolling. Still needs some cleaning but I won't have much time in the foreseeable future to dedicate to it. Anyone willing to take over, please do feel free to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69490
Closes #59319
Closes #57400
So far, this is a PR for testing purposes. I'd appreciate feedback and thoughts from @WordPress/gutenberg-core
In the Site Editor 'view' mode, the editor canvas iframe is meant to be a preview. Clicking the whole area of the preview switches the editor to 'edit' mode. This is implemented by hacking around the
iframeelement adding arole=buttonto it, a click event callback etc, It's a hack with many problems for accessibility:By using a native, transparent, button overlaid on top of the preview iframe, this PR tries a more standard approach.
Why?
How?
Uses a transparent button on top o fthe preview iframe.
So far, the button is semi-transparent for testing purposes. Ultimately, it should be fully transparent.
Testing Instructions
Edit button.Testing Instructions for Keyboard
Screenshots or screencast