Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated @since Doc Order in Inline documentation #68003

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

shail-mehta
Copy link
Member

Need to Update According to Php Coding Standard in Below File

  • lib/block-supports/block-style-variations.php @since Should add before @see tag

@shail-mehta shail-mehta added the [Type] Developer Documentation Documentation for developers label Dec 15, 2024
@shail-mehta shail-mehta self-assigned this Dec 15, 2024
@shail-mehta shail-mehta changed the title Updated @since Order in Inline documentation Updated @since Doc Order in Inline documentation Dec 15, 2024
@shail-mehta shail-mehta marked this pull request as ready for review December 15, 2024 10:50
Copy link

github-actions bot commented Dec 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think a similar fix needs to be made to the core as well:

https://github.com/t-hamano/wordpress-develop/blob/a27e6a8ecd5279a45e47ef88d048643740d07b5a/src/wp-includes/block-supports/block-style-variations.php#L201

As previously suggested in this comment, could you submit a core ticket, a core patch, and add a backport changelog to this PR?

@shail-mehta
Copy link
Member Author

Thanks for the Feedback.

I forgot to add backport pr changelog url i will update it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants