Latest Post Block: Refactor settings panel to use ToolsPanel #67956
Conversation
This reverts commit 63f81c1.
karthick-murugan
requested review from
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
karthick-murugan
changed the title
There was a problem hiding this comment.
This one needs a little more refinement.
- We should ensure that every single control inside any of the
ToolsPanelcomponent gets their ownToolsPanelItem - The UI of the Featured Image settings currently has some spacing issues:
- We should ensure that all the defaults that render by default today have the
isShownByDefaultprop added so they cannot get removed.
| <ToolsPanelItem | ||
| hasValue={ () => order !== undefined } | ||
| label={ __( 'Sorting options' ) } | ||
| onDeselect={ () => | ||
| setAttributes( { order: 'desc', orderBy: 'date' } ) | ||
| } | ||
| > |
There was a problem hiding this comment.
Instead of one ToolsPanelItem called Sorting Options we should have each of the elements in this section as it's own ToolsPanelItem. That requires a bit of a larger refactor but we need to ensure each item can be reset on its own.
fabiankaegy
added
[Type] Enhancement
|
@fabiankaegy - Only fixed the spacing issues on the Featured Image settings. Need some advice on how to proceed for converting ImageSizeControl and QueryControls options to have their own reset and toolspanelitems. |
What?
Part of: #67813
Fixes #67931
Why?
Latest Post Block code to include ToolsPanel instead of PanelBody.
How?
Refactored Latest Post Block code to include ToolsPanel instead of PanelBody.
Testing Instructions
Screenshots or screencast
Before
After