CreateTemplatePartModalContents: use native radio inputs #67702
Merged
+140
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Feature] UI Components
|
Size Change: -78 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
refactor/create-template-part-modal-contents-vanilla-radio
branch
from
aebc4ff to
74d7f7b
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
force-pushed
the
refactor/create-template-part-modal-contents-vanilla-radio
branch
from
74d7f7b to
70dd1e7
Compare
ciampo
commented
Dec 7, 2024
packages/fields/src/components/create-template-part-modal/index.tsx
Outdated
Show resolved
Hide resolved
ciampo
force-pushed
the
refactor/create-template-part-modal-contents-vanilla-radio
branch
from
70dd1e7 to
e65ea97
Compare
|
Good change. Probably not something to discuss here, but we could potentially remove all the customisations and use the vanilla component... 
Either that, or formalise this design treatment as a variant so it can be reused elsewhere. |
mirka
reviewed
Dec 10, 2024
packages/fields/src/components/create-template-part-modal/index.tsx
Outdated
Show resolved
Hide resolved
packages/fields/src/components/create-template-part-modal/index.tsx
Outdated
Show resolved
Hide resolved
packages/fields/src/components/create-template-part-modal/index.tsx
Outdated
Show resolved
Hide resolved
packages/fields/src/components/create-template-part-modal/style.scss
Outdated
Show resolved
Hide resolved
Comment on lines
+71
to
+73
| input[type="radio"]:not(:checked) ~ & { | ||
| opacity: 0; | ||
| } |
|
By the way I'm getting a "The 'useSelect' hook returns different values when called with the same state and parameters" warning when opening the modal, but confirmed it's already an issue in trunk. |
This caught my attention 🙂 and I believe I have a fix in #67786. Please try to apply the fix and let me know if it eliminates the warning for you. I didn't do much testing myself 🙂 |
I love this idea. #66615 will be a prerequisite for this. |
My preference would be to remove the customization, instead of introducing a new variant. Does this mean that we should stop working on this PR, wait for #66615 and then refactor using |
#67786 landed already, so the warning should disappear after rebasing to the latest |
|
I'd probably lean towards proceeding with the PR as-is, to avoid changing the shipping UI. We can then revisit the design in a dedicated issue and evaluate:
|
ciampo
force-pushed
the
refactor/create-template-part-modal-contents-vanilla-radio
branch
from
e65ea97 to
34a93cd
Compare
|
Rebased and addressed all feedback. I'm good with merging this PR and then iterating with a new design in a separate issue. |
jameskoster
approved these changes
Dec 16, 2024
ciampo
deleted the
refactor/create-template-part-modal-contents-vanilla-radio
branch
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…7702) * Refactor to vanilla radio inputs, rewrite styles * Remove unnecessary classname * Apply instance ID to all ids and radio names * Use darker shade of gray for description --- Co-authored-by: ciampo <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: jsnajdr <[email protected]> Co-authored-by: tyxla <[email protected]>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…7702) * Refactor to vanilla radio inputs, rewrite styles * Remove unnecessary classname * Apply instance ID to all ids and radio names * Use darker shade of gray for description --- Co-authored-by: ciampo <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: jsnajdr <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #66569
Refactor the
CreateTemplatePartModalContentscomponent to use native<input type="radio" />elements instead of the deprecatedRadioGroupcomponentWhy?
The
RadioGroupcomponent is deprecated and we shouldn't use it in the repository.This refactor brings in other several benefits:
fieldsetandlegend;How?
fieldset,legend,radioandlabel)Testing Instructions
trunk(apart from the differences listed above)Screenshots or screencast
Kapture.2024-12-07.at.00.57.36.mp4
Kapture.2024-12-07.at.01.01.40.mp4