Try to navigate to section: /revisions from the revisions button #67660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
ramonjd
changed the title
|
Size Change: +132 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
ramonjd
force-pushed
the
try/styles-add-revisions-to-panel
branch
from
a5017c3 to
3a01d40
Compare
|
Flaky tests detected in a1543d8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12226926868
|
This was referenced Dec 12, 2024
ramonjd
commented
Dec 15, 2024
| @@ -138,19 +138,21 @@ function ScreenRevisions() { | |||
| { hasRevisions && | |||
| ( editorCanvasContainerView === | |||
| 'global-styles-revisions:style-book' ? ( | |||
| <StyleBook | |||
| <GlobalStylesStyleBook | |||
There was a problem hiding this comment.
As explanation: a shared component is required as revisions needs to send a global styles config to the style book.
ramonjd
commented
Dec 15, 2024
| setEditorCanvasContainerView( 'global-styles-revisions' ); | ||
| }, [ openGlobalStyles, setEditorCanvasContainerView ] ); | ||
| const openRevisions = useCallback( () => { | ||
| if ( 'style-book' === editorCanvasContainerView ) { |
There was a problem hiding this comment.
Note: this PR has exposed the clunky way we're loading the editor canvas views. There are significant "flashes" when navigating between revisions and the main styles panel in view mode.
I'm not sure of an alternative that maintains current functionality, probably to create a bespoke stylebook component for the view mode, which is duplication of effort and maintenance.
Or better handling of transitions between editor views using CSS or something.
All this is keeping the pot simmering while a better presentation layer to load global-styles related editor views is worked out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploratory stage.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast