Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .components-item-group selector in edit-site components[2] #67575

Merged
merged 3 commits into from
Dec 8, 2024
Merged

Remove .components-item-group selector in edit-site components[2] #67575

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9903d20
fix: Removed .components-item-group selector class usage in scss file…
im3dabasia Dec 4, 2024
6b9684e
fix: Added sidebar-navigation-screen-main/style.scss file correctly
im3dabasia Dec 4, 2024
0dcd8f8
refactor: CSS code for sidebar in editor
im3dabasia Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-dataviews/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function DataViewsSidebarContent( { postType } ) {

return (
<>
<ItemGroup>
<ItemGroup className="edit-site-sidebar-dataviews">
{ defaultViews.map( ( dataview ) => {
return (
<DataViewItem
Expand Down
5 changes: 5 additions & 0 deletions packages/edit-site/src/components/sidebar-dataviews/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
}
}

.edit-site-sidebar-dataviews {
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;
}

.edit-site-sidebar-dataviews-dataview-item {
border-radius: $radius-small;
padding-right: $grid-unit-10;
Expand Down
5 changes: 5 additions & 0 deletions packages/edit-site/src/components/sidebar-navigation-item/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
.edit-site-sidebar-navigation-screen-templates-browse {
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;
}

.edit-site-sidebar-navigation-item.components-item {
color: $gray-600;
// 6px right padding to align with + button
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen-main/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { store as editSiteStore } from '../../store';

export function MainSidebarNavigationContent() {
return (
<ItemGroup>
<ItemGroup className="edit-site-sidebar-navigation-screen-main">
<SidebarNavigationItem
uid="navigation-navigation-item"
to="/navigation"
Expand Down
4 changes: 4 additions & 0 deletions packages/edit-site/src/components/sidebar-navigation-screen-main/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.edit-site-sidebar-navigation-screen-main {
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;
}
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen-navigation-menus/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export default function SidebarNavigationScreenNavigationMenus( { backPath } ) {

return (
<SidebarNavigationScreenWrapper backPath={ backPath }>
<ItemGroup>
<ItemGroup className="edit-site-sidebar-navigation-screen-navigation-menus">
{ navigationMenus?.map( ( { id, title, status }, index ) => (
<NavMenuItem
postId={ id }
Expand Down
5 changes: 5 additions & 0 deletions packages/edit-site/src/components/sidebar-navigation-screen-navigation-menus/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
margin: 0 0 $grid-unit-40 0;
}

.edit-site-sidebar-navigation-screen-navigation-menus {
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;
}

.edit-site-sidebar-navigation-screen-navigation-menus__content {
.block-editor-list-view-leaf .block-editor-list-view-block__contents-cell {
width: 100%;
Expand Down
2 changes: 2 additions & 0 deletions packages/edit-site/src/components/sidebar-navigation-screen-patterns/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
.edit-site-sidebar-navigation-screen-patterns__group {
margin-bottom: $grid-unit-30;
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;

&:last-of-type {
border-bottom: 0;
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen-templates-browse/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export default function DataviewsTemplatesSidebarContent() {
}, [ records ] );

return (
<ItemGroup>
<ItemGroup className="edit-site-sidebar-navigation-screen-templates-browse">
<SidebarNavigationItem
to="/template"
icon={ layout }
Expand Down
5 changes: 0 additions & 5 deletions packages/edit-site/src/components/sidebar-navigation-screen/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@
.edit-site-sidebar-navigation-screen__content {
padding: 0 $grid-unit-20;

.components-item-group {
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;
}

.components-text {
color: $gray-400;
}
Expand Down
1 change: 1 addition & 0 deletions packages/edit-site/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
@import "./components/pagination/style.scss";
@import "./components/global-styles/variations/style.scss";
@import "./components/sidebar-global-styles-wrapper/style.scss";
@import "./components/sidebar-navigation-screen-main/style.scss";

/* stylelint-disable -- Disable reason: View Transitions not supported properly by stylelint. */
::view-transition-image-pair(root) {
Expand Down
Loading