Preload: add testing for post editor and pages in site editor #67511
+69
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
Merged
|
Should we just copy the test for the post editor in the |
|
@Mamaduka Not sure what you mean? It's a tiny super fast test so I'm not sure if it matters much. |
Do you mind rebasing to avoid accidental surprise when this is merged? |
ellatrix
force-pushed
the
add/more-preload-testing
branch
from
ce2150a to
6791c7f
Compare
|
@Mamaduka Done :) |
|
It seems we've an "expected values" mismatch now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds tests to prevent regressions in preloading (and thus load performance) for the post editor and page editor within the site editor.
Why?
To prevent regressions and make people more aware. These tests are meant to catch regressions early instead of after the fact in performance graphs. It's also much more scalable to test all kinds of different pages.
How?
Use the recording added in #67475.
Testing Instructions
n/a