-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Add stories for BlockTitle Component #67234
base: trunk
Are you sure you want to change the base?
Storybook: Add stories for BlockTitle Component #67234
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi @t-hamano, I have made the necessary changes to the PR based on the general feedback provided. Additionally, I reviewed other similar PRs with requested changes and implemented those adjustments as well. Could you kindly take a look at the PR when you have a moment? Thank you! 2024-12-11.00-52-17.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! If you have any questions about the feedback I left, feel free to ask 👍
packages/block-editor/src/components/block-title/stories/index.story.js
Outdated
Show resolved
Hide resolved
clientId: { | ||
control: { | ||
type: 'select', | ||
labels: { | ||
[ blocks[ 0 ].clientId ]: "Paragraph's Client ID", | ||
[ blocks[ 1 ].clientId ]: "Heading's Client ID", | ||
[ blocks[ 2 ].clientId ]: "Group's Client ID", | ||
}, | ||
}, | ||
options: [ | ||
blocks[ 0 ].clientId, | ||
blocks[ 1 ].clientId, | ||
blocks[ 2 ].clientId, | ||
], | ||
description: 'Client ID of block.', | ||
table: { | ||
type: { | ||
summary: 'string', | ||
}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clientId: { | |
control: { | |
type: 'select', | |
labels: { | |
[ blocks[ 0 ].clientId ]: "Paragraph's Client ID", | |
[ blocks[ 1 ].clientId ]: "Heading's Client ID", | |
[ blocks[ 2 ].clientId ]: "Group's Client ID", | |
}, | |
}, | |
options: [ | |
blocks[ 0 ].clientId, | |
blocks[ 1 ].clientId, | |
blocks[ 2 ].clientId, | |
], | |
description: 'Client ID of block.', | |
table: { | |
type: { | |
summary: 'string', | |
}, | |
}, | |
}, | |
clientId: { | |
description: 'Client ID of block.', | |
table: { | |
type: { | |
summary: 'string', | |
}, | |
}, | |
}, |
Personally, I don't think this control needs to be selectable since this component is only concerned with the title string and it doesn't really matter what the block is.
packages/block-editor/src/components/block-title/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-title/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-title/stories/index.story.js
Outdated
Show resolved
Hide resolved
…ovider - Replaced BlockEditorProvider with ExperimentalBlockEditorProvider. - Simplified blocks array to include a single paragraph block. - Removed unnecessary client ID mappings and control options. - Cleaned up redundant comments and controls.
Hey @t-hamano, I’ve implemented the suggested changes as recommended. Let me know if there’s anything else you’d like me to adjust. Thank you! |
Part of #67165
What?
This PR adds Storybook stories for the
BlockTitle
component to improve component documentation and testability.Why?
Testing Instructions
npm run storybook:dev
Screencast
Screen.Recording.2024-11-22.at.6.53.22.PM.mov