Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Header layout spacing in Firefox #67074

Conversation

Mayank-Tripathi32
Copy link
Contributor

resolves #67069

What?

I have adjusted the column widths to improve layout responsiveness in Firefox.

Why?

When the browser width was reduced to approximately 1200px or lower, the "Save Draft" text began overlapping with the document bar, causing a misalignment.

How?

To address this, I updated the styles for the .editor-header using the :has selector and modified the template widths to enhance responsiveness across different screen sizes.

grid-template: auto / $header-height minmax(min-content, 2fr) 2.5fr minmax(min-content, 2fr) $header-height;

Testing Instructions

  1. Open the Firefox browser and create a new page.
  2. Resize the browser window to approximately 1200px in width.
  3. Verify that the "Save Draft" text no longer appears behind the document bar, as demonstrated in the screenshot provided.
  4. Repeat same for "chrome" & "safari"

ScreenCast

Screen.Recording.2024-11-18.at.5.19.52.PM.mov

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: SainathPoojary <[email protected]>
Co-authored-by: maddisondesigns <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 18, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Mayank-Tripathi32! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my tests and there is a big improvement when compared to trunk. The button may still be a little hidden (e.g: at 960px window size) but never becomes totally unusable.

@jorgefilipecosta jorgefilipecosta merged commit 8dd99aa into WordPress:trunk Nov 27, 2024
65 of 66 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Nov 27, 2024
michalczaplinski pushed a commit that referenced this pull request Dec 5, 2024
Co-authored-by: jorgefilipecosta <[email protected]>
Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: SainathPoojary <[email protected]>
Co-authored-by: maddisondesigns <[email protected]>
@ramonjd ramonjd added the [Package] Editor /packages/editor label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of the new Zoom Out button breaks UI layout on smaller browser widths
4 participants