Enable zoom out mode for non-iframe editor #66789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -19 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
stokesman
approved these changes
Nov 6, 2024
t-hamano
force-pushed
the
zoom-out-non-iframed
branch
from
4a014e1 to
88516fe
Compare
|
@stokesman Thanks for the review! |
|
Tested this and worked all right - there is a weirder animation when the editor is not framed but I agree that if we keep the pattern behaviour we should add the button too. |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: ellatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66671
What?
This PR re-enables the zoom out toggle for the non-iframe editor that was disabled in #65452.
Why?
Selecting the Pattern tab forces the zoom out mode. This is correct behavior, but creates a contradiction because the non-iframe editor doesn't have the zoom out toggle button in the first place. The zoom out toggle button suddenly appears, but when you press it, it disappears.
This PR simply reverts #65452. When #65452 was submitted, zoom out mode didn't work in non-iframe editors. But now it seems to work correctly. The introduction of the
useZoomout()hook or #66141 might be related.Testing Instructions
wp/6.7branch, the meta boxes are not displayed in the zoom out mode (See Hide metaboxes in Zoom Out #66742). There is a discussion in Hide meta boxes when zoomed out #66718 about whether to implement this specification in trunk as well.Screenshots or screencast
b6352f628d5006a33fc9da05bf8ecfc6.mp4