-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command: View page/post #66720
base: trunk
Are you sure you want to change the base?
Add command: View page/post #66720
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @benazeer-ben! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working really well, thank you!
I tested posts and pages in the site editor (published and non-published), and also pages in the site editor.
The command appears as expected with the correct label, depending on the post status. ✅
I think for the first iteration it might be safer to limit the postType
to page
or post
for now.
What do you think?
Looks like this PR needs a quick rebase too. |
…o enhancement/command-palette-view-page
Hi @ramonjd Thanks for your review and suggestions.
Yes, right. As per the ticket definition it is mentioning support for pages. So this PR is mainly developed for pages and posts, we can consider the other postTypes later as you suggested. |
Co-authored-by: Ramon <[email protected]>
I think it just needs a quick rebase and we're good to go 👍🏻 |
What?
Enhancement for the scenario mentioned in #55806
Why?
Currently view page/post command is not available.
How?
Added command for viewing page/ post from command box.
Testing Instructions
Screenshots or screencast
view-page-post.mp4