Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuItem: Add 40px size prop on Button #66596

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Conversation

mirka
Copy link
Member

@mirka mirka commented Oct 30, 2024

In preparation for #65751

What?

Adds __next40pxDefaultSize prop to the Button in MenuItem.

Testing Instructions

See the MenuItem stories in Storybook. The heights should now be 40px instead of 36px.

MenuItem with 40px height

(These changes mostly won't be seen in the app until we update the styles for DropdownMenu, which is currently overriding the MenuItem styles 😅)

@mirka mirka added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Oct 30, 2024
@mirka mirka self-assigned this Oct 30, 2024
Copy link

Flaky tests detected in 34a50fa.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11593300372
📝 Reported issues:

@mirka mirka marked this pull request as ready for review October 30, 2024 14:31
@mirka mirka requested a review from ajitbohra as a code owner October 30, 2024 14:31
@mirka mirka requested a review from a team October 30, 2024 14:31
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant