Zoom out: Add keyboard shortcut in editor #66400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
Oct 24, 2024
Mamaduka
reviewed
Oct 24, 2024
packages/block-editor/src/components/keyboard-shortcuts/index.js
Outdated
Show resolved
Hide resolved
Mamaduka
approved these changes
Oct 24, 2024
|
Size Change: +103 B (+0.01%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
add/zoom-out-shortcut
branch
from
efa08f6 to
8cdf4d5
Compare
|
Sorry for stopping automerge. This shortcut also appears in the widget editor/customize widget editor, which I don't think is intended.
|
|
It looks like it would be better to add the shortcut here in the editor package instead of the block editor package, and set the namespace to |
ntsekouras
force-pushed
the
add/zoom-out-shortcut
branch
from
8cdf4d5 to
badcae7
Compare
ntsekouras
changed the title
Thank you @t-hamano! I added it to editor then, although it feels a bit weird to me that the functionality exists in block editor. On the other hand the shortcut has a bigger 'area' and we have similar shortcuts. |
|
Thanks for the update! I have confirmed that this command works on Windows OS as well. Another thing I noticed is that the shortcut appears even though the zoom out is not available. i.e. pattern editor, non-iframe editor, etc:
I'm not sure if this PR needs to address this, but I think it will have to be addressed at some point. |
|
I think "editor" is the right place for it personally. Yes, block-editor supports zoom-out by default but block-editor shouldn't control the state of zoom-out, it should be just an immutable setting there (I know we have some places where we exit zoom-out in block-editor... today, but I think we should remove these ideally). |
ntsekouras
force-pushed
the
add/zoom-out-shortcut
branch
from
badcae7 to
fc50e88
Compare
|
I moved the registration of the shortcut in |
|
I couldn't find a simpler shortcut with |
|
Browsers have |
|
Number keys seem fairly common for zoom settings. Here’s the ones from Preview on mac OS |
|
|
|
I updated to ⇧⌘0 and will merge for now. |
swissspidy
pushed a commit
that referenced
this pull request
Oct 25, 2024
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: stokesman <[email protected]>
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: stokesman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #50739
This PR adds a zoom out shortcut in block editor.: (⇧⌘0)
We could also add a command for this.
Testing Instructions
Test the above shortcut that works.